Date: Sun, 24 May 2015 18:36:19 -0600 From: Ian Lepore <ian@freebsd.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Oleksandr Tymoshenko <gonzo@freebsd.org>, "freebsd-arm@freebsd.org List" <freebsd-arm@freebsd.org> Subject: Re: panic: arm_unmask_irq [was: Re: TI platforms code update: switching to vendor FDT data] Message-ID: <1432514179.1200.17.camel@freebsd.org> In-Reply-To: <8EC96924-4D33-4AF8-87B7-586441601D0B@xcllnt.net> References: <C9791C97-D5B1-433A-9AC0-CA2707C6137F@freebsd.org> <72E1D87A-1CEF-4719-907E-CF8E9D720FD1@xcllnt.net> <3741A6A7-1185-4E5A-9E98-22F5A6C730DC@freebsd.org> <1432512966.1200.15.camel@freebsd.org> <8EC96924-4D33-4AF8-87B7-586441601D0B@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2015-05-24 at 17:33 -0700, Marcel Moolenaar wrote: > > On May 24, 2015, at 5:16 PM, Ian Lepore <ian@freebsd.org> wrote: > > > > Shouldn't the driver attach order be controlled with BUS_PASS numbers > > now? That's been required with other socs that moved to the standard > > dts data where we don't control the order of the nodes in the file. > > The problem is different in my case, but yes it was the first > thing I suspected without digging deeper: > > fbsdvm64% svn diff sys/arm > Index: sys/arm/ti/aintc.c > =================================================================== > --- sys/arm/ti/aintc.c (revision 283321) > +++ sys/arm/ti/aintc.c (working copy) > @@ -156,7 +156,8 @@ > > static devclass_t ti_aintc_devclass; > > -DRIVER_MODULE(aintc, simplebus, ti_aintc_driver, ti_aintc_devclass, 0, 0); > +EARLY_DRIVER_MODULE(aintc, simplebus, ti_aintc_driver, ti_aintc_devclass, > + 0, 0, BUS_PASS_ORDER_EARLY); > > int > arm_get_next_irq(int last_irq) > > > -- > Marcel Moolenaar > marcel@xcllnt.net > For an interrupt controller that should probably be BUS_PASS_INTERRUPT + BUS_PASS_ORDER_MIDDLE We have to do some fine-grained tuning in some cases and there are only a few predefined categories and they're spaced really close together. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1432514179.1200.17.camel>