From owner-freebsd-acpi@FreeBSD.ORG  Thu Nov 17 22:33:05 2005
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
X-Original-To: acpi@freebsd.org
Delivered-To: freebsd-acpi@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F2BEE16A41F;
	Thu, 17 Nov 2005 22:33:04 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5B03143D46;
	Thu, 17 Nov 2005 22:33:04 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.5.50] (ppp-71-139-0-107.dsl.snfc21.pacbell.net
	[71.139.0.107])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id jAHMX1De023304
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Thu, 17 Nov 2005 14:33:06 -0800
Message-ID: <437D04FC.90707@root.org>
Date: Thu, 17 Nov 2005 14:32:28 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200511171725.27877.jhb@freebsd.org>
In-Reply-To: <200511171725.27877.jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: acpi@freebsd.org
Subject: Re: [PATCH] Fix weird PCI bus numbers with pci_linkX
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2005 22:33:05 -0000

John Baldwin wrote:
> I think I figured out why some people get messages like:
> 
> pci_linkX: BIOS IRQ 11 for -17777216.6.INTA is invalid
> 
> I was not reading the bus number from the bridge device correctly (the normal 
> __BUS_ACCESSOR() macros assume that the passed in argument is a child device, 
> but at the time I'm reading the bus there is no child device, so I was 
> passing in the pcib device, the parent of the pcib device probably returned 
> an error, and the bus variable ended up being some random stack garbage).  
> The attached patch (also at URL) should fix it I think.
> 
> http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch

Excellent, patch looks good to me except the printf/panic message could 
be improved.

-- 
Nate