Date: Mon, 14 Oct 2002 16:36:23 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Julian Elischer <julian@elischer.org>, Juli Mallett <jmallett@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_switch.c Message-ID: <200210142336.g9ENaNXY005679@apollo.backplane.com> References: <Pine.BSF.4.21.0210141512450.63899-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This feature is available to everyone via their freefall account.
Only a couple of people are using it but I personally find it
extremely useful. The filter picks out the commits I might be
interested in, I can delete the ones out of that set that do not
interest me at the time, and it's a no-brainer to give the rest a once
over. It's been rather enlightening, in fact.
Login to your freefall account and then cd ~dillon/filters. Create
a file named the same as your username. I suggest starting with the
SAMPLE file. You can also look at other people's files to see what
they do, such as mine. For example, my filter grabs commits made
into src/ and tags the Subject: with [src], then mails it to my
main mailbox on apollo.backplane.com. Make sure perms are 644 (640
might work too).
The documentation is in ~dillon/dfilter/README on freefall.
Eventually I'll make a port out of it and write a real man page.
Ultimately I would like to use this filter mechanism to filter
PR submissions and mailing list submissions in addition to commits.
In fact I tried subscribing myself to the PR mailing list but I
guess the moderator lost it. The filter can filter on anything in
the message... any header, or the body, so it can be useful to tag
PRs that one might be interested in as well as commit messages.
To expand it to that, though, I want to move it out of my personal
account and into a special account. No special privilages are needed
other then read-only repository access.
Personally I do not think we should try to build the diff set into
the commit mechanism itself. The commit mechanism should be as simple
and straightforward as possible in order to ensure that we do not
accidently introduce a billion bugs or unnecessarily slow down the
commit process (think of the very large commits that occassionally
must be done). And not everyone wants or needs a diff for every
single commit either!
-Matt
Matthew Dillon
<dillon@backplane.com>
:I subscribe to Matt's "enhanced" commit messages that show the diff
:as well. I always check the diff after a checkin to check that I checked
:in what I though I checked in.. In this case I saw a braino, where
:I put a line in the wrong place by 2 lines..
:
:
:On Mon, 14 Oct 2002, Juli Mallett wrote:
:
:> * De: Julian Elischer <julian@FreeBSD.org> [ Data: 2002-10-14 ]
:> [ Subjecte: cvs commit: src/sys/kern kern_switch.c ]
:> > julian 2002/10/14 13:43:02 PDT
:> >
:> > Modified files:
:> > sys/kern kern_switch.c
:> > Log:
:> > Did you ever notice how stupid bugs show up much clearer
:> > when you see them in a commit message?
:>
:> Huh?
:> --
:> Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve
:> Will break world for fulltime employment. | finger jmallett@FreeBSD.org
:> http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210142336.g9ENaNXY005679>