From owner-freebsd-gecko@FreeBSD.ORG Thu Oct 10 01:26:16 2013 Return-Path: Delivered-To: gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F160679 for ; Thu, 10 Oct 2013 01:26:16 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from smtp.rcn.com (smtp.rcn.com [69.168.97.78]) by mx1.freebsd.org (Postfix) with ESMTP id A527A23ED for ; Thu, 10 Oct 2013 01:26:16 +0000 (UTC) X_CMAE_Category: 0,0 Undefined,Undefined X-CNFS-Analysis: v=2.1 cv=CO4TA3bD c=1 sm=0 tr=0 a=fEl05wXzeJCkBz9gs2itqQ==:117 a=N1DYviGaBlcA:10 a=komF9lS4R6EA:10 a=YNqtyO0l_hcA:10 a=LaogzpLLAAAA:8 a=fwHJhBxoPTcA:10 a=r77TgQKjGQsHNAKrUKIA:9 a=9iDbn-4jx3cA:10 a=cKsnjEOsciEA:10 a=O0dnTMeQGSTuFAKuhqoA:9 a=wPNLvfGTeEIA:10 a=XoZLRo2-rr75_73quEIA:9 a=_W_S_7VecoQA:10 a=QfKxxUxMAAAA:8 a=tBJQrbSEsOY4M4dPQcYA:9 a=sOKxrc_Uve4A:10 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.mail=mi+thun@aldan.algebra.com; spf=neutral; sender-id=neutral Authentication-Results: smtp02.rcn.cmh.synacor.com header.from=mi+thun@aldan.algebra.com; sender-id=neutral Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.user=anat; auth=pass (PLAIN) Received-SPF: neutral (smtp02.rcn.cmh.synacor.com: 209.6.63.29 is neither permitted nor denied by domain of aldan.algebra.com) Received: from [209.6.63.29] ([209.6.63.29:36264] helo=utka.zajac) by smtp.rcn.com (envelope-from ) (ecelerity 2.2.3.49 r(42060/42061)) with ESMTPA id 22/65-15841-63206525; Wed, 09 Oct 2013 21:26:15 -0400 Message-ID: <52560236.9090006@aldan.algebra.com> Date: Wed, 09 Oct 2013 21:26:14 -0400 From: "Mikhail T." User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: gecko@freebsd.org Subject: Allow thunderbird port to build with any compiler Content-Type: multipart/mixed; boundary="------------040706090201020209040001" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Oct 2013 01:26:17 -0000 This is a multi-part message in MIME format. --------------040706090201020209040001 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello! The "fix" of requiring a special gcc for Thunderbird (and Seamonkey) on i386 is an abomination. If a library is reporting a missing symbol, it needs to be linked with a library, that defines the symbol (-lnspr4 in this case). Careful reading of ldap/sdks/c-sdk/ldap/libraries/libprldap/Makefile.in shows, that libprldap is already being linked with NSPR-libraries on various platforms -- but not (yet?) on FreeBSD. I don't know, why we haven't seen this problem yet with gcc (or on the 64-bit platforms), but the proper fix is to include the necessary libraries -- not to force the "special" compiler. Please, apply the attached patch and let the healing begin. Something very similar is needed for Seamonkey... Thank you. Yours, -mi --------------040706090201020209040001 Content-Type: text/plain; charset=KOI8-U; name="fix-thunderbird.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-thunderbird.patch" Index: Makefile =================================================================== --- Makefile (revision 329910) +++ Makefile (working copy) @@ -74,11 +74,6 @@ XPI_LIBDIR= ${PREFIX}/lib/xpi -# libprldap60.so: Undefined symbol "PR_GetCurrentThread" -.if ${ARCH} == i386 -USE_GCC?= yes -.endif - .if ${PORT_OPTIONS:MENIGMAIL} MASTER_SITES+= https://www.enigmail.net/download/source/:enigmail DISTFILES+= ${EM_DISTFILE}:enigmail Index: files/patch-ldap-sdks-c-sdk-ldap-libraries-libprldap-Makefile.in =================================================================== --- files/patch-ldap-sdks-c-sdk-ldap-libraries-libprldap-Makefile.in (revision 329910) +++ files/patch-ldap-sdks-c-sdk-ldap-libraries-libprldap-Makefile.in (working copy) @@ -1,11 +1,12 @@ --- ldap/sdks/c-sdk/ldap/libraries/libprldap/Makefile.in.orig 2008-09-11 16:38:35.000000000 +0200 +++ ldap/sdks/c-sdk/ldap/libraries/libprldap/Makefile.in 2009-12-01 10:18:43.000000000 +0100 -@@ -147,6 +147,11 @@ +@@ -147,6 +147,12 @@ CUSTOM_LIBS=1 endif +ifeq ($(OS_ARCH), FreeBSD) +EXTRA_LIBS = -L$(dist_libdir) -l$(LBER_LIBNAME) -lpthread ++EXTRA_LIBS+= $(filter -L% -l%,${NSPRLINK}) +CUSTOM_LIBS=1 +endif + --------------040706090201020209040001--