From owner-svn-src-head@freebsd.org Thu Dec 21 00:36:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23916E8AA59 for ; Thu, 21 Dec 2017 00:36:56 +0000 (UTC) (envelope-from erj@erj.cc) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE3766A8AC for ; Thu, 21 Dec 2017 00:36:55 +0000 (UTC) (envelope-from erj@erj.cc) Received: by mail-it0-x241.google.com with SMTP id o130so13050587itg.0 for ; Wed, 20 Dec 2017 16:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erj.cc; s=ericroxx; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SXo7LrkGYF6d7/YbzGUxtE8+FcImt8Qxx3Zeb8KEr+k=; b=TPOLhMI/FYiPzoLcLUx8fEIwAfI3gL4tiH6U7mn886WNhsWgED7bc2JgqtMcEPMU7J J22wHHiXH9H49ZrCvujjuxzeHrTqLaGf8xaDMMUeZtSzndtJ6E2yk/KCbmUmozVcNSaF lvAeZoaqlprKjfJbo4bTxcev0pdrTr//dpkf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SXo7LrkGYF6d7/YbzGUxtE8+FcImt8Qxx3Zeb8KEr+k=; b=DMtPx4m5+FArWU/hrbuq6jjlB4Vz8pi7TXeBRQohStDINUTNXVKNQGEk0MafHx5lrd agmaqcO42soWsIpKNiq3Vo1C3brTDggA4CQrBjekbj1q/QuaNslrndW4+EOvKKlZV/Dm 0SZqrowb7xgGqBlNP8v+r/XF3D9KW3E+Bsni6CUqvmWk1qMxdCSd/qzOQ1a9j2mUi7wZ /Ouas8kwrHFUPnxJ6FoMO90yVyemoTVSN/5Psqf1HtLLtAlJNejgcx2Fjt5VOK2stwxW govsRDZkYam1Nb5lINZIDQqBTcJgqEnJxialKvztpkAFDH0QOTK67cbSbSeUMhUoAcfG cPwg== X-Gm-Message-State: AKGB3mIPAtGFEjZYAueMvOAQdIvCWijcVc8NVQuWYWO9iDCSIhcL53qq xgNx/+dIpswVCNMWt2E1JmwUTSJXHM8n0preV/TazQ== X-Google-Smtp-Source: ACJfBovNOQH5ojwKrW5J7YVq3LLLRepT6jpTaghsTea/n2mdHNbNUncJv+oQDDIs6hGdE/RWXsTqZqmSuSd/ljUUf2k= X-Received: by 10.36.145.216 with SMTP id i207mr10567224ite.73.1513816615150; Wed, 20 Dec 2017 16:36:55 -0800 (PST) MIME-Version: 1.0 References: <201712201815.vBKIF6IN062349@repo.freebsd.org> <20171220193237.GA11032@raichu> <1513800135.29087.25.camel@freebsd.org> In-Reply-To: <1513800135.29087.25.camel@freebsd.org> From: Eric Joyner Date: Thu, 21 Dec 2017 00:36:44 +0000 Message-ID: Subject: Re: svn commit: r327031 - in head/sys: conf dev/ixgbe modules/ix modules/ixv To: Ian Lepore Cc: Mark Johnston , cramerj@intel.com, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 00:36:56 -0000 On Wed, Dec 20, 2017 at 12:02 PM Ian Lepore wrote: > On Wed, 2017-12-20 at 19:47 +0000, Eric Joyner wrote: > > On Wed, Dec 20, 2017 at 11:32 AM Mark Johnston > wrote: > > > > > > > > On Wed, Dec 20, 2017 at 06:15:06PM +0000, Eric Joyner wrote: > > > > > > > > Author: erj > > > > Date: Wed Dec 20 18:15:06 2017 > > > > New Revision: 327031 > > > > URL: https://svnweb.freebsd.org/changeset/base/327031 > > > > > > > > Log: > > > > ixgbe(4): Convert driver to use iflib > > > > [...] > > > This seems to have broken at least the i386 kernel build. Could you > > > please take a look? > > > > > > https://ci.freebsd.org/job/FreeBSD-head-i386-build/5330/console > > > > We probably missed this because we pretty much only use amd64 for > testing; > > it looks like for that error we can just change that ULONG to a UQUAD. > I'll > > add Jeb to this thread. > > > > - Eric > > A good way to avoid such trouble when touching kernel/module code that > compiles on multiple arches is to do a "make lintkernels". > > Before you can do that, you need to do "make kernel-toolchains" just > once, which may take a while -- it has to build clang for each arch, > which is a bit annoying since every instance of clang is already a > cross-compiler and our build process doesn't make use of that fact. > > -- Ian > > Thanks for the report and tips, guys. It should be fixed in r327051. An i386 build didn't show any other errors. - Eric