From owner-cvs-src@FreeBSD.ORG  Thu Jan 15 14:54:20 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B96F816A4CE; Thu, 15 Jan 2004 14:54:20 -0800 (PST)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0CF9343D46; Thu, 15 Jan 2004 14:54:19 -0800 (PST)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id i0FMsIH68194;
	Thu, 15 Jan 2004 17:54:18 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
Date: Thu, 15 Jan 2004 17:54:18 -0500 (EST)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Don Lewis <truckman@FreeBSD.org>
In-Reply-To: <200401150519.i0F5JO7E041440@gw.catspoiler.org>
Message-ID: <20040115175353.O36463-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_util.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2004 22:54:20 -0000


On Wed, 14 Jan 2004, Don Lewis wrote:

> On 14 Jan, Jeff Roberson wrote:
> > On Wed, 14 Jan 2004, Don Lewis wrote:
> >
> >> truckman    2004/01/14 14:38:03 PST
> >>
> >>   FreeBSD src repository
> >>
> >>   Modified files:
> >>     sys/compat/linux     linux_util.c
> >>   Log:
> >>   VOP_GETATTR() wants the vnode passed to it to be locked.  Instead
> >>   of adding the code to lock and unlock the vnodes and taking care
> >>   to avoid deadlock, simplify linux_emul_convpath() by comparing the
> >>   vnode pointers directly instead of comparing their va_fsid and
> >>   va_fileid attributes.  This allows the removal of the calls to
> >>   VOP_GETATTR().
> >
> > I'm not sure that the vnode pointer compare works in the case of device
> > aliasing.  Any comments?
>
> I believe you are correct, though one would hope that /compat/linux
> wasn't a device.  The va_fsid and va_fileid test would not work either.
> For devices you want to look at va_rdev.
>

Ah, ok, sorry.  I didn't bother to see what the path you were comparing
was.

Thanks,
Jeff