From owner-cvs-src@FreeBSD.ORG Tue Dec 25 06:45:55 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD8AA16A41B; Tue, 25 Dec 2007 06:45:55 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail13.syd.optusnet.com.au (mail13.syd.optusnet.com.au [211.29.132.194]) by mx1.freebsd.org (Postfix) with ESMTP id 7C2FF13C455; Tue, 25 Dec 2007 06:45:55 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from server.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mail13.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id lBP6jqQS012042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Dec 2007 17:45:53 +1100 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.2/8.14.1) with ESMTP id lBP6jqUV053535; Tue, 25 Dec 2007 17:45:52 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.2/8.14.2/Submit) id lBP6jqlg053534; Tue, 25 Dec 2007 17:45:52 +1100 (EST) (envelope-from peter) Date: Tue, 25 Dec 2007 17:45:52 +1100 From: Peter Jeremy To: Edwin Groothuis Message-ID: <20071225064552.GE53085@server.vk2pj.dyndns.org> References: <200712250040.lBP0eWn5060702@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <200712250040.lBP0eWn5060702@repoman.freebsd.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.17 (2007-11-01) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/cp cp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2007 06:45:56 -0000 --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 25, 2007 at 12:40:32AM +0000, Edwin Groothuis wrote: > When copying multiple files to a directory, make sure that a proper > warning is given when the directory doesn't exist. warnx("Target is not a directory"); exit(1); would be more simply expressed as errx(1, "Target is not a directory"); Maybe you should report the target name: errx(1, "%s is not a directory", to.p_path); > Submitted by: Edwin Groothuis Normally, you don't bother listing yourself as the author. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHcKcg/opHv/APuIcRAt4zAKDEDYGLsu5kl69QjlR7Jbs7iaBxDwCfebyU jJBoDLmtVbU56iMAyEqUh28= =anQ9 -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--