From owner-dev-commits-src-all@freebsd.org Mon Jul 26 18:57:05 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A4A16731B1; Mon, 26 Jul 2021 18:57:05 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [IPv6:2001:19f0:6400:80a1:5054:ff:fe7a:a27d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYTgP3K2Fz3Mpn; Mon, 26 Jul 2021 18:57:05 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.16.1/8.16.1) with ESMTP id 16QIuuvC054697; Mon, 26 Jul 2021 21:56:56 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.16.1/8.16.1/Submit) id 16QIuuGH054696; Mon, 26 Jul 2021 21:56:56 +0300 (MSK) (envelope-from dchagin) Date: Mon, 26 Jul 2021 21:56:56 +0300 From: Dmitry Chagin To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: de273c83a10c - main - linux(4): Fix i386 gcc build. Message-ID: References: <202107261829.16QIThWa081478@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4GYTgP3K2Fz3Mpn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 18:57:05 -0000 On Mon, Jul 26, 2021 at 07:37:45PM +0100, Jessica Clarke wrote: > On 26 Jul 2021, at 19:29, Dmitry Chagin wrote: > > > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=de273c83a10c5807b52b7479e477854b77baa912 > > > > commit de273c83a10c5807b52b7479e477854b77baa912 > > Author: Dmitry Chagin > > AuthorDate: 2021-07-26 18:28:16 +0000 > > Commit: Dmitry Chagin > > CommitDate: 2021-07-26 18:28:16 +0000 > > > > linux(4): Fix i386 gcc build. > > > > Do not specify memory model for i386. Seems that clang silencly > > ignores -mcmodel unlike gcc. > > > > Reported by: jhb > > MFC after: 2 weeks > > --- > > sys/modules/linux/Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/sys/modules/linux/Makefile b/sys/modules/linux/Makefile > > index 1304c2d91fd8..bf4449e0012e 100644 > > --- a/sys/modules/linux/Makefile > > +++ b/sys/modules/linux/Makefile > > @@ -60,20 +60,20 @@ linux${SFX}_assym.h: linux${SFX}_genassym.o > > sh ${SYSDIR}/kern/genassym.sh linux${SFX}_genassym.o > ${.TARGET} > > > > .if ${MACHINE_CPUARCH} == "amd64" > > -VDSOFLAGS=-DCOMPAT_FREEBSD32 -DCOMPAT_LINUX32 -m32 > > +VDSOFLAGS=-DCOMPAT_FREEBSD32 -DCOMPAT_LINUX32 -m32 -mcmodel=small > > This just shifts the problem. You’ve fixed it if building an i386 > kernel, but not if building an amd64 kernel with linux32 support. > This line should just be reverted and everything should work fine. > Aha, I see, seems that I'm in a command now how builds everything by gcc)