Date: Thu, 29 Dec 2016 18:09:39 +0100 From: "Piotr P. Stefaniak" <pstef@freebsd.org> To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> Cc: Michael Tuexen <tuexen@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r310773 - in stable/11/sys: netinet netinet6 Message-ID: <20161229170939.GA23243@freefall.freebsd.org> In-Reply-To: <201612291438.uBTEcARM006548@pdx.rh.CN85.dnsmgr.net> References: <201612291132.uBTBWgLM065597@repo.freebsd.org> <201612291438.uBTEcARM006548@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2016-12-29 06:38:10, Rodney W. Grimes wrote: >> Author: tuexen >> Date: Thu Dec 29 11:32:42 2016 >> New Revision: 310773 >> URL: https://svnweb.freebsd.org/changeset/base/310773 >> >> Log: >> MFC r310590: >> >> Whitespace changes. >> >> The toolchain for processing the sources has been updated. No function= al >> change. > >What tool chain? It is still broken in at least 1 respect: It's indent(1) from FreeBSD HEAD. >> /* now use the rest of the mbuf chain for the text */ >> while (m_tmp !=3D NULL) { >> if ((SCTP_BUF_NEXT(m_tmp) =3D=3D NULL) && trailer) { >> - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, >> + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, > = ^^^^^^^^^^^^^^ >> SCTP_BUF_LEN(m_tmp) - (trailer + m_offset)); >> } else { >> - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, >> + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, > = ^^^^^^^^^^^ > >> SCTP_BUF_LEN(m_tmp) - m_offset); >> } >> >... others errors of this type occur in this patch. This is caused by an old bug in indent that hasn't presented itself until -ta was used to automatically recognize tokens ending with "_t" as type names. >I think it would of been better to revert the old patch that messed up som= e comments >before creating this change as now there are other changes intermingled ma= king the 2 >changes inter-dependent. Two things have changed since that old patch that you refer to: 1) newest version of FreeBSD indent(1) was used 2) the option -ta was added It's the 1) that fixed comment formatting (broken earlier by me) since the old patch. It's the 2) that is responsible for some of the corrections that you applaud. It's also 2) that is responsible for uncovering the old bug in indent that I haven't fixed yet. >Even with this small nit, I applaud the number of style(9) corrections! > >--=20 >Rod Grimes rgrimes@freebsd= =2Eorg > --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEElaLNZulp/QcHQR2KSnkqwcVL7lkFAlhlQ0oACgkQSnkqwcVL 7lll2Qf/a7/MsUfXnmbwtk5fl9UnxMi72UDWHFwXIy4h1sHcvp31cDN9wPp1H+wa b04mRF6MSVmeMjpxeITlT8PG7oHcgP1DIU8mZuw5Lb9Z8SfAN7fdvArXVPJvLiOB cOIQHg4HXs+QOfcwe4qCx49BQkIzx+sWlXq1tNF7/xyyxMme9/k6EKyEcwWESbfv s2nGvWtEBl+hsO7fkfzlwN3bOzUzexwIwIQOkd0mbkaBmbz5BmsuY5usUyvApxpo cBkax+alezMPQLbEMCAwEY8ceyYOgpodwfUeY9XMq+HNMrxn67NUBVE9Hr7GVKPe H5Khig9EtyNAJBJwpLmas//rC7jnUA== =TNcf -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161229170939.GA23243>