From owner-svn-src-head@FreeBSD.ORG Mon Mar 30 16:20:48 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A454E4DF; Mon, 30 Mar 2015 16:20:48 +0000 (UTC) Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1]) by mx1.freebsd.org (Postfix) with ESMTP id 5E4C5A32; Mon, 30 Mar 2015 16:20:47 +0000 (UTC) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id C39A12704531; Mon, 30 Mar 2015 18:20:46 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 81EDB27044B0; Mon, 30 Mar 2015 18:20:46 +0200 (CEST) Received: from work.netasq.com ([127.0.0.1]) by localhost (work.netasq.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8dS9kmSxZZP6; Mon, 30 Mar 2015 18:20:46 +0200 (CEST) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 3E76827044AE; Mon, 30 Mar 2015 18:20:46 +0200 (CEST) Date: Mon, 30 Mar 2015 18:20:45 +0200 (CEST) From: Emeric POUPON To: Gleb Smirnoff Message-ID: <964618150.26750606.1427732445799.JavaMail.zimbra@stormshield.eu> In-Reply-To: <20150330152707.GP64665@FreeBSD.org> References: <20150329210757.GA64665@FreeBSD.org> <551943B4.90102@selasky.org> <20150330125115.GI64665@FreeBSD.org> <551948A4.1070408@selasky.org> <5519535C.40608@selasky.org> <20150330141616.GC74532@zxy.spb.ru> <1872802434.26738716.1427729028579.JavaMail.zimbra@stormshield.eu> <20150330152707.GP64665@FreeBSD.org> Subject: Re: svn commit: r280759 - head/sys/netinet MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thread-Topic: svn commit: r280759 - head/sys/netinet Thread-Index: jtXFy+DUqhLgWCHCoPorh8rEWMCt8A== Cc: Hans Petter Selasky , Adrian Chadd , src-committers@freebsd.org, Ian Lepore , svn-src-all@freebsd.org, Slawa Olhovchenkov , svn-src-head@freebsd.org, Fabien Thomas X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 16:20:48 -0000 Yes, sure! I will test it tomorrow and tell you the results. However, keep in mind I did not see any performance impact with the previou= s patch. Regards, ----- Mail original ----- De: "Gleb Smirnoff" =C3=80: "Emeric POUPON" Cc: "Slawa Olhovchenkov" , "Hans Petter Selasky" , "Adrian Chadd" , src-committers@freebsd.org, "= Ian Lepore" , svn-src-all@freebsd.org, svn-src-head@freebs= d.org, "Fabien Thomas" Envoy=C3=A9: Lundi 30 Mars 2015 17:27:07 Objet: Re: svn commit: r280759 - head/sys/netinet On Mon, Mar 30, 2015 at 05:23:48PM +0200, Emeric POUPON wrote: E> Hello, E>=20 E> Sorry for late response, I didn't notice this issue was discussed here. E>=20 E> In one of our tests, we have several (up to 12) cpu that emit packets wi= th the same src, dst and protocol to a remote host. E> We did this patch since we observed bad packet reassembly on the remote = host, due to different fragments emitted with the same ip id. E> It was an IPsec test (emitting ESP packets) but I guess we could easily = reproduce this problem using several "ping -i 0 -s BIG_SIZE_HERE DST" comma= nds running in parallel. E>=20 E> Even if we reached something like 1M pps, it is likely that we did not s= ee any performance penalty since the IPsec stack is quite time consuming. E> Now, the question is: is there a real performance issue here or is it li= kely to be hidden by other problems? E>=20 E> If it is a real problem, maybe an acceptable tradeoff would be to make t= he counter per CPU and: E> - initialize it with the cpu id, E> - increment it by the number of cpus. E>=20 E> What do you think? I already posted a patch that makes the counter per CPU. Can you please tes= t it? --=20 Totus tuus, Glebius.