From owner-freebsd-ports Tue Nov 12 13:26:34 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADB9737B401 for ; Tue, 12 Nov 2002 13:26:32 -0800 (PST) Received: from aaz.links.ru (aaz.links.ru [193.125.152.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id A839A43E3B for ; Tue, 12 Nov 2002 13:26:31 -0800 (PST) (envelope-from babolo@aaz.links.ru) Received: from aaz.links.ru (aaz.links.ru [193.125.152.37]) by aaz.links.ru (8.12.6/8.12.6) with ESMTP id gACLSBDh055002; Wed, 13 Nov 2002 00:28:11 +0300 (MSK) (envelope-from babolo@aaz.links.ru) Received: (from babolo@localhost) by aaz.links.ru (8.12.6/8.12.6/Submit) id gACLSAoU055001; Wed, 13 Nov 2002 00:28:10 +0300 (MSK) Message-Id: <200211122128.gACLSAoU055001@aaz.links.ru> Subject: Re: Thinking about PORTCOMMENTS X-ELM-OSV: (Our standard violations) hdr-charset=KOI8-R; no-hdr-encoding=1 In-Reply-To: To: Garance A Drosihn Date: Wed, 13 Nov 2002 00:28:10 +0300 (MSK) From: "."@babolo.ru Cc: Kris Kennaway , freebsd-ports@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL99b (25)] MIME-Version: 1.0 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > At 6:27 PM -0800 11/11/02, Kris Kennaway wrote: > >On Mon, Nov 11, 2002, Garance A Drosihn wrote: > > > >> Is the value of the proposed PORTCOMMENT value actually used in > >> any make-targets? Or is it just read by some program to generate > >> HTML pages? (...this is the part that I should have investigated > >> more...). > > > >Yes, it's used in several make targets and therefore needs to be > >readable by make. > > Well, I still have to apologize that I have not had the time to > look at this in detail, but I skimmed through the update that > Eric Melville had posted to see just how the value is used. It > looks like the variable is simply copied into a file via: > ${MAKE} -V PORTCOMMENT > ${WRKDIR}/comment > > and then that file is used. My guess is that it should be just as > easy to skim the Makefile for the "fake-xml" setting, as it is to > recursively call 'make' and process several hundred lines of > make files and .included make files just to get the value of one > variable. Am I right in assuming the only value of that variable > that matters is the one in the ports own Makefile? (ie, that it > would not be set via some .included file). And is the goal simply > to remove the "pkg-comment" file? Or are there greater ideas > involved, such as making the comment include values of other > 'make' variables? > > And now for the part where I almost look more helpful instead of > merely annoying: If my above assumptions are right, should I try > to implement something which does what I'm talking about with > these fake-xml settings? I could probably come up with something > this weekend, or at least work long enough at that if I have no > success I will shut up about it for awhile... Why to do complicated that can be simple? head -1 pkg-deskr > ${WRKDIR}/comment is much easely then fake-xml (if comment is first descr string) or grep '^#COMMENT ' Makefile | sed -e 's|^#COMMENT ||' | head -1 > comment if comment is part of Makefile (fake-comment :-). -- @BABOLO http://links.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message