From owner-freebsd-stable@freebsd.org Thu Jul 5 11:58:53 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36C3A10449EF for ; Thu, 5 Jul 2018 11:58:53 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A7BAB77E5D; Thu, 5 Jul 2018 11:58:52 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wm0-x244.google.com with SMTP id v3-v6so6795299wmh.0; Thu, 05 Jul 2018 04:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=yJA9w1YioNvtWmcv0I/Z2mNa3SrylSHkkGy4vPmMwnc=; b=d65+8irMVtruqldFycdB0tyPGH54ZuM0Ze8oKOiEbFQ54lumXwh/GQkTYnMbSj2LU0 gO7iuPteB2yEcnQfm3/kHuAfT+qQRoEzX9fm7cjs1NlATltRqFFheq4MnX08OaTlry4R bAUkCvOs9j+Gb7MBpOffNgoERA+xACNSI34w0rEepZ7uRbClzPo0RIx2ht5TQnI/x4Gg EUGLhnGgbK/sYRpLZaPP6xoWaEGXFFcrPHupKCBzW/VS1cq09Ow/Chx+4tIDVnxEHP/N d30uDm3bcqIBn7tAy8BEEanwIOlSViB3Cq0jNVgt39sl7J8VP9jSp+qWdC80WAa7cAtP GrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:content-language :thread-index; bh=yJA9w1YioNvtWmcv0I/Z2mNa3SrylSHkkGy4vPmMwnc=; b=acPBNMP0Q0vRKtte1NiTN7DB1g+qkKMmNDwXQWU1ILK0C8l3vApPsRQ74nviG+eC6l IoEwFzxg1DPotv1dsmkCCh6n6Yn+Lca+FRgLeU/gbbJrvQoH5gxnsU7/5GK6nNtmyDJi PoCtI/nKxvJeObMW6VgeNv5y+SKdtk8O3Wabr8axw6QYr6PY0+Y2hIOkYQHfAAGuY07n 6JzhS6HDtactys6etpBw0vv1khxZnRFhiVe2N8aR1aei+uFvJXdpDn+5Xl+YJAkJ5qfe gHTur/ERrUAJdJ7TbkXrLb6Zlaf9jbM6ycPjTdomDYWiT8FR4WS/zF2bVTbR/BbjExIU 5yRA== X-Gm-Message-State: APt69E28D+WJ2WHBQ0RLuZ8hBsoaMo4aJIDFNPgVaDkm4JJyNgwg7VnE JUyVtexpgrPUvHp0/ZuhrLDNBw6b X-Google-Smtp-Source: AAOMgpe5bjx4iS6bR+IG7BPnJ1Dz8niLq0Qd7Bsi+j3a4PKgueW3So7iM/L0bZP9cBCexKrg/fzsDA== X-Received: by 2002:a5d:4452:: with SMTP id x18-v6mr4700561wrr.227.1530791931216; Thu, 05 Jul 2018 04:58:51 -0700 (PDT) Received: from DriesPC (ptr-8sibhe27nh9xc4j1ahg.18120a2.ip6.access.telenet.be. [2a02:1811:2503:a700:39f5:ab63:beca:6e54]) by smtp.gmail.com with ESMTPSA id a203-v6sm8009704wme.46.2018.07.05.04.58.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 04:58:50 -0700 (PDT) From: "Dries Michiels" To: "'Konstantin Belousov'" Cc: References: <006601d4144e$993ad000$cbb07000$@gmail.com> <20180705110505.GF5562@kib.kiev.ua> In-Reply-To: <20180705110505.GF5562@kib.kiev.ua> Subject: RE: Kernel build fails Date: Thu, 5 Jul 2018 13:58:50 +0200 Message-ID: <007601d41457$89f91620$9deb4260$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: nl-be Thread-Index: AQG53nWcD+kRNyE/ZnRCJifu5BxaVQLs0/ZppJ2HxnA= X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:58:53 -0000 > > --- kern_jail.o --- > > > > /usr/src/sys/kern/kern_jail.c:3943:15: error: unused variable 'p' > > [-Werror,-Wunused-variable] > > > > struct proc *p; > > > > ^ > > > > /usr/src/sys/kern/kern_jail.c:3944:16: error: unused variable 'cred' > > [-Werror,-Wunused-variable] > > > > struct ucred *cred; > > > > ^ > > > > 2 errors generated. > > You have RACCT but not RCTL in the kernel config ? Try this. This is correct! > diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c index > b8bcbd49420..457a590cdf5 100644 > --- a/sys/kern/kern_jail.c > +++ b/sys/kern/kern_jail.c > @@ -3988,8 +3988,10 @@ prison_racct_attach(struct prison *pr) static > void prison_racct_modify(struct prison *pr) { > +#ifdef RCTL > struct proc *p; > struct ucred *cred; > +#endif > struct prison_racct *oldprr; > > ASSERT_RACCT_ENABLED(); I'm trying the patch as we speak thanks kib. Atlough after some digging I see that the kernel option RACCT on itself isn't really useful and should probably be combined with RCTL. Do you agree?