Date: Thu, 15 Sep 2005 11:33:54 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: pyunyh@gmail.com Cc: freebsd-current@freebsd.org, Ariff Abdullah <skywizard@MyBSD.org.my> Subject: documenting the locking requirements? (was: Re: panic upon kldunload snd_ich (lor # 159)) Message-ID: <20050915113354.iv5u8ycfksscw4wk@netchild.homeip.net> In-Reply-To: <20050915043448.GB18332@rndsoft.co.kr> References: <47d0403c05091121047a037946@mail.gmail.com> <20050912044212.GC5182@rndsoft.co.kr> <47d0403c05091122276fd0a231@mail.gmail.com> <20050913070149.GE9481@rndsoft.co.kr> <47d0403c0509131235ed58122@mail.gmail.com> <20050914014830.GA13631@rndsoft.co.kr> <20050915033848.2d87da42.skywizard@MyBSD.org.my> <20050915014509.GA17602@rndsoft.co.kr> <20050915114653.431f17c5.skywizard@MyBSD.org.my> <20050915043448.GB18332@rndsoft.co.kr>
next in thread | previous in thread | raw e-mail | index | archive | help
Pyun YongHyeon <pyunyh@gmail.com> wrote: > > I tend to agree with you. Since that sndstat_busy() isn't enough, how > > about we acquire the entire sndstat so nobody can monkey with it (as the > > proposed / attached diff) and at the same time avoiding this LOR > > message. It seems much better rather than locking sndstat after > > sndstat_busy() and much of pcm_unregister() procedures, only to find out > > that somebody acquire it within that moment. > > > > I didn't try the patch but it looks good to me. :-) > If you have more time would you please fix race in sndstat_open()? > > Minor note : I think it is better to use sx_xunlock ranther than > sx_unlock as sx_xunlock clearly indicates which type of locks held. Are the locking requirements (what needs to be locked and why/when, in which order) in the sound code documented somewhere? If yes: where? If no: can I convince you (either one or both of "you") to write something up (plain text would be enough for a start)? Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Overheard: "How do I feel? Great! And I kiss pretty good, too!"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050915113354.iv5u8ycfksscw4wk>