From owner-svn-src-head@freebsd.org Tue Oct 22 15:33:58 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 866CD15DB3F; Tue, 22 Oct 2019 15:33:58 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46yHbn3qk2z3Qqv; Tue, 22 Oct 2019 15:33:57 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 9326C260105; Tue, 22 Oct 2019 17:33:48 +0200 (CEST) Subject: Re: svn commit: r353876 - head/sys/kern To: Gleb Smirnoff , Li-Wen Hsu , br@freebsd.org Cc: src-committers , svn-src-all , svn-src-head References: <201910212312.x9LNCEbX052414@repo.freebsd.org> <20191022152913.GJ4086@FreeBSD.org> From: Hans Petter Selasky Message-ID: <55116590-d3ca-00ea-29c6-f32adfcdea9e@selasky.org> Date: Tue, 22 Oct 2019 17:31:27 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191022152913.GJ4086@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46yHbn3qk2z3Qqv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; IP_SCORE(-2.63)[ip: (-9.16), ipnet: 2a01:4f8::/29(-2.15), asn: 24940(-1.82), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 15:33:58 -0000 On 2019-10-22 17:29, Gleb Smirnoff wrote: > L> > L> panic: Assertion (vm_offset_t)et >= td->td_kstack && (vm_offset_t)et + > L> sizeof(struct epoch_tracker) < td->td_kstack + td->td_kstack_pages * > L> PAGE_SIZE failed at /workspace/src/sys/kern/subr_epoch.c:373 Probably doesn't matter that much, but the last comparison should be less than or equal, instead of only less than, off-by-one, if the element is on top of stack ??? sizeof(struct epoch_tracker) XXX <= XXX td->td_kstack + td->td_kstack_pages --HPS