From owner-freebsd-current@FreeBSD.ORG Tue Nov 27 21:44:16 2007 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03B6416A421 for ; Tue, 27 Nov 2007 21:44:16 +0000 (UTC) (envelope-from jasone@freebsd.org) Received: from canonware.com (canonware.com [64.183.146.166]) by mx1.freebsd.org (Postfix) with ESMTP id DFA5A13C467 for ; Tue, 27 Nov 2007 21:44:15 +0000 (UTC) (envelope-from jasone@freebsd.org) Received: from [192.168.168.201] (canonware.com [64.183.146.166]) by canonware.com (Postfix) with ESMTP id AC30A1298D3; Tue, 27 Nov 2007 13:15:41 -0800 (PST) Message-ID: <474C88F3.9040301@freebsd.org> Date: Tue, 27 Nov 2007 13:15:31 -0800 From: Jason Evans User-Agent: Thunderbird 1.5.0.12 (X11/20071018) MIME-Version: 1.0 To: Alexander Kabaev References: <200711271622.lARGMLSB066265@repoman.freebsd.org> <20071127135729.4c5c6f89@kan.dnsalias.net> In-Reply-To: <20071127135729.4c5c6f89@kan.dnsalias.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@FreeBSD.org Subject: Versions.def (was Re: cvs commit: src/lib/libc/gen Symbol.map) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2007 21:44:16 -0000 Alexander Kabaev wrote: > On Tue, 27 Nov 2007 16:22:21 +0000 (UTC) > Jason Evans wrote: >> Modified files: >> lib/libc/gen Symbol.map >> Log: >> Add _pthread_mutex_init_calloc_cb to libc's map, for which malloc >> defines a stub. > > Is it a new function in FreeBSD 8.0 or are you planning to commit it to > FreeBSD 7.0-current. If it is for 8.0 only, it does not belong where > you put it. My intent is to MFC this change after FreeBSD 7.0 is released. This brings up some questions and problems. This change adds _pthread_mutex_init_calloc_cb as a private interface that is implemented by lib{c,thr,kse}, so from the user's perspective there is no API change, but of course the libraries have to be in sync with each other. 1) Do we need to introduce a new namespace to src/lib/libc/Versions.def for such a change? 2) If we do introduce a new namespace in RELENG_7, does that mean that every time we MFC an interface, we have to add a new namespace? 3) Suppose that we do add the FBSDprivate_1.1 namespace. It it a successor to FBSD_1.1 or FBSDprivate_1.0? It appears that we cannot have it both ways, which leads me to suspect that FBSDprivate_1.0 should not be a successor to FBSD_1.0 (i.e. it should have no dependencies), and that FBSDprivate_1.1 should be a successor to FBSDprivate_1.0. FWIW, it looks like once we get the Versions.def issues figured out, I'm guessing that _pthread_mutex_init_calloc_cb should be in src/lib/libc/stdlib/Symbol.map since its definition is in the stdlib directory rather than the gen directory. Thanks, Jason