From owner-svn-src-all@FreeBSD.ORG Mon Jan 9 19:20:31 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B881B106564A; Mon, 9 Jan 2012 19:20:31 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 50A198FC15; Mon, 9 Jan 2012 19:20:31 +0000 (UTC) Received: by yenl9 with SMTP id l9so1923856yen.13 for ; Mon, 09 Jan 2012 11:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=efZe7/+Q+dFtKXTlYkIbWLLJtF2RkhC1Rh9/cigduVo=; b=x4DI1a54Xy9C4yWjti4+KIlsWyEGktJbUIDpzHyuUEczzHCBRIGYh95VpPcUxSul1V V4Db2+Dgd/rRnWsb1IEXGOfwUNl9vf6iKtoHnI8bY7+Qjvy0JrsbKqnG2BZUI1Y6AgEP r+ILA82OlRkQCWgBmThNXumcmmSVD8jpD5eXs= MIME-Version: 1.0 Received: by 10.236.122.237 with SMTP id t73mr10734310yhh.124.1326135243889; Mon, 09 Jan 2012 10:54:03 -0800 (PST) Sender: maksim.yevmenkin@gmail.com Received: by 10.101.41.18 with HTTP; Mon, 9 Jan 2012 10:54:03 -0800 (PST) In-Reply-To: <201112282249.pBSMnTZu028304@svn.freebsd.org> References: <201112282249.pBSMnTZu028304@svn.freebsd.org> Date: Mon, 9 Jan 2012 10:54:03 -0800 X-Google-Sender-Auth: j4CMW2yzOjwGjnFZTJxqLL9zM9g Message-ID: From: Maksim Yevmenkin To: Alexander Motin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228939 - head/sys/dev/mps X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 19:20:31 -0000 On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin wrote: > Author: mav > Date: Wed Dec 28 22:49:28 2011 > New Revision: 228939 > URL: http://svn.freebsd.org/changeset/base/228939 > > Log: > =A0Set maximum I/O size for mps(4) to MAXPHYS. Looking into the code, I s= ee > =A0no reason why it should be limited to 64K of DFLTPHYS. DMA data tag is= any > =A0way set to allow MAXPHYS, S/G lists (chain elements) are sufficient an= d > =A0overflows are also handled. On my tests even 1MB I/Os are working fine= . > > =A0Reviewed by: =A0ken@ > > Modified: > =A0head/sys/dev/mps/mps_sas.c > > Modified: head/sys/dev/mps/mps_sas.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/mps/mps_sas.c =A0Wed Dec 28 22:18:53 2011 =A0 =A0 =A0 = =A0(r228938) > +++ head/sys/dev/mps/mps_sas.c =A0Wed Dec 28 22:49:28 2011 =A0 =A0 =A0 = =A0(r228939) > @@ -937,6 +937,7 @@ mpssas_action(struct cam_sim *sim, union > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpi->transport_version =3D 0; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpi->protocol =3D PROTO_SCSI; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpi->protocol_version =3D SCSI_REV_SPC; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 cpi->maxio =3D MAXPHYS; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpi->ccb_h.status =3D CAM_REQ_CMP; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break; > =A0 =A0 =A0 =A0} sorry for the late reply, but can we make in into tunable please? i have in local tree --- mps_sas.c.orig 2011-11-17 02:05:04.000000000 -0800 +++ mps_sas.c 2011-12-28 16:05:10.000000000 -0800 @@ -121,6 +121,11 @@ MALLOC_DEFINE(M_MPSSAS, "MPSSAS", "MPS SAS memory"); +int mps_maxio =3D MAXPHYS; +TUNABLE_INT("hw.mps.maxio", &mps_maxio); +SYSCTL_INT(_hw_mps, OID_AUTO, maxio, CTLFLAG_RD, &mps_maxio, 0, + "CAM maxio override\n"); + static __inline int mpssas_set_lun(uint8_t *lun, u_int ccblun); static struct mpssas_target * mpssas_alloc_target(struct mpssas_softc *, struct mpssas_target *); @@ -938,6 +943,7 @@ cpi->protocol =3D PROTO_SCSI; cpi->protocol_version =3D SCSI_REV_SPC; cpi->ccb_h.status =3D CAM_REQ_CMP; + cpi->maxio =3D mps_maxio; break; } case XPT_GET_TRAN_SETTINGS: thanks, max