From owner-svn-ports-all@FreeBSD.ORG Mon Mar 23 08:20:51 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4E176F8C; Mon, 23 Mar 2015 08:20:51 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 20648114; Mon, 23 Mar 2015 08:20:50 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 390D443BB9; Mon, 23 Mar 2015 03:20:35 -0500 (CDT) Message-ID: <550FCCCA.2010308@marino.st> Date: Mon, 23 Mar 2015 09:20:26 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Alexey Dokuchaev , Bryan Drewery Subject: Re: svn commit: r381955 - head/graphics/gdal References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323032725.GA55962@FreeBSD.org> In-Reply-To: <20150323032725.GA55962@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sunpoet Po-Chuan Hsieh , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 08:20:51 -0000 On 3/23/2015 04:27, Alexey Dokuchaev wrote: > On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: >> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: >>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrote: >>>> New Revision: 381955 >>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 >>>> QAT: https://qat.redports.org/buildarchive/r381955/ >>>> >>>> Log: >>>> - Use -lpthread instead of -pthread >>> >>> Is -pthread going away anytime soon? I'm a bit worried of more alike >>> changing one to another; since they're identical right now on FreeBSD, >>> I'd rather reduce amount of patching, leaving whatever is picked by >>> upstream, unless -lpthread really should be preferred over -pthread >>> for some reason I'm unaware of (and ready to learn about). >> >> It's a pointless change. Tijl explains here >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198116#c4 > > Right; I'm aware of Tijl's excellent explanation (broader version he posted > on the lists) and given that it is a pointless change, I used this occasion > to remind that commits that merely change one to another should be avoided. > It's not pointless; people are patching good "-lpthread" to be "-pthread" even today, and it's hard to tell them to stop when the default PTHREADS_LIBS is "-pthread". Also, this is not what tijl has been saying -- his stance was to stop using -pthread. We need not to add more -pthread, we need to remove patches and sed of -lpthread to -pthread, and to do that we need to start at the infrastructure to avoid sending a mixed message. patching -lpthread to -pthread is simply wrong now, and the message needs to get out. John