Date: Mon, 25 Feb 2008 03:59:56 +0100 From: Lars Balker Rasmussen <lars@balker.dk> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: ports@freebsd.org, perl@freebsd.org Subject: Re: Port dependencies on p5-Test-* Message-ID: <20080225025956.GC13264@tux.nerdheaven.dk> In-Reply-To: <86zltpzrxt.fsf@ds4.des.no> References: <86zltpzrxt.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 25, 2008 at 03:32:46AM +0100, Dag-Erling Smørgrav wrote:
> There is a ridiculous amount of p5-* ports that have completely
> unnecessary build dependencies on p5-Test-*. These package are usually
> only needed to run unit tests (cd ${WRKSRC} && make test), which *none*
> of those ports do.
>
> (ridiculous, in this case, means close to 300)
>
> What's worse, most of these ports have RUN_DEPENDS = ${BUILD_DEPENDS},
> which means even the prebuilt packages have these unnecessary
> dependencies!
>
> All of this could be avoided by adding these few lines to the port's
> Makefile, and removing p5-Test-* from BUILD_DEPENDS:
>
> pre-configure:
> @(cd ${WRKSRC} && ${REINPLACE_CMD} -E -e \
> "s/'?Test::[^']+'?[[:space:]]*=>[[:space:]]'?[0-9.]+'?,//" \
> Makefile.PL)
>
> (some ports also need to edit Build.PL)
>
> Alternatively, this could be added to bsd.perl.mk, conditional on the
> presence of a PERL_UNTESTIFY_FILES variable which would list Makefile.PL
> and / or Build.PL for the ports that require it.
I completely agree, and have been weeding both practices from my ports
when I touch them. Maybe a blanket sweep of all Test:: dependencies is
is in order.
(Even better, obsolete 5.6 so Test::More is in core-perl, making it all
the simpler.)
--
Lars Balker Rasmussen Consult::Perl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080225025956.GC13264>