From owner-svn-src-head@FreeBSD.ORG  Tue Nov 22 13:11:17 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 652B9106564A;
	Tue, 22 Nov 2011 13:11:17 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 398558FC19;
	Tue, 22 Nov 2011 13:11:17 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id C996646B06;
	Tue, 22 Nov 2011 08:11:16 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5C868B921;
	Tue, 22 Nov 2011 08:11:16 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Marius Strobl <marius@alchemy.franken.de>
Date: Mon, 21 Nov 2011 16:38:54 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; )
References: <201111191011.pAJABp0N034812@svn.freebsd.org>
	<201111211116.47529.jhb@freebsd.org>
	<20111121183933.GK56603@alchemy.franken.de>
In-Reply-To: <20111121183933.GK56603@alchemy.franken.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201111211638.54748.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 22 Nov 2011 08:11:16 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>
Subject: Re: svn commit: r227701 - in head/sys: arm/xscale/ixp425 dev/ahci
	dev/ata dev/gpio dev/mvs dev/ppbus dev/ppc dev/siba dev/siis
	dev/usb kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2011 13:11:17 -0000

On Monday, November 21, 2011 1:39:33 pm Marius Strobl wrote:
> On Mon, Nov 21, 2011 at 11:16:47AM -0500, John Baldwin wrote:
> > On Saturday, November 19, 2011 5:11:51 am Hans Petter Selasky wrote:
> > > Author: hselasky
> > > Date: Sat Nov 19 10:11:50 2011
> > > New Revision: 227701
> > > URL: http://svn.freebsd.org/changeset/base/227701
> > > 
> > > Log:
> > >   Move the device_delete_all_children() function from usb_util.c
> > >   to kern/subr_bus.c. Simplify this function so that it no longer
> > >   depends on malloc() to execute. Identify a few other places where
> > >   it makes sense to use device_delete_all_children().
> > >   
> > >   MFC after:	1 week
> > 
> > Sorry I didn't review this earlier when you sent it to me.  In general I
> > think this is a good idea, and reducing the duplicated code is great.
> 
> Could we rename it to just device_delete_children(9)? Using both "all" and
> the plural seems redundant and doesn't match device_get_children(9) which
> also operates on all children.

That sounds like a good idea.

-- 
John Baldwin