From owner-cvs-src@FreeBSD.ORG Sun Apr 20 18:50:07 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB744106566B; Sun, 20 Apr 2008 18:50:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 6794F8FC14; Sun, 20 Apr 2008 18:50:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 001D141C7A4; Sun, 20 Apr 2008 20:50:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id 35QA9hZyng2S; Sun, 20 Apr 2008 20:50:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 9B78641C7A3; Sun, 20 Apr 2008 20:50:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 1AFED44487F; Sun, 20 Apr 2008 18:48:45 +0000 (UTC) Date: Sun, 20 Apr 2008 18:48:45 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200804201836.m3KIax4S070088@repoman.freebsd.org> Message-ID: <20080420183726.R66744@maildrop.int.zabbadoz.net> References: <200804201836.m3KIax4S070088@repoman.freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: Re: cvs commit: src/sys/netinet tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2008 18:50:07 -0000 On Sun, 20 Apr 2008, Bjoern A. Zeeb wrote: > bz 2008-04-20 18:36:59 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_var.h > Log: > Revert to rev. 1.161 - switch back to optimized TCP options ordering. > > A lot of testing has shown that the problem people were seeing was due > to invalid padding after the end of option list option, which was corrected > in tcp_output.c rev. 1.146. > > Thanks to: anders@, s3raphi, Matt Reimer > Thanks to: Doug Hardie and Randy Rose, John Mayer, Susan Guzzardi > Special thanks to: dwhite@ and BitGravity > Discussed with: silby > MFC after: 1 day > > Revision Changes Path > 1.162 +2 -5 src/sys/netinet/tcp_var.h A few more words on this: 1) the short MFC time is because the past has shown that HEAD does not uncover any problems with changes like this and we'd like to move towards an errata for this so RELENG_7 exposure time should be as long as possible. 2) With all the testing I have only seen 1 client having problems with the optimized ordering but that client also had other (connectivity) problems so I was told to ignore that one. 3) I have seen clients failing with the RELENG_6 (now old again) option ordering as well. 4) The cable modems/routers blamed before in any of the threads actually worked correctly not accepting a TCP packet with bad padding violating the TCP RFC. Lats but not least, I hope to be able to find the time to further summarize the problems seen, the things discovered, etc. at a later time. I have yet to look at another few strange TCP connections found during all of the testing (some of which seem to have hit net@ or stable@ the last days as well.) /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.