From owner-freebsd-hackers Wed Feb 7 00:26:14 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id AAA09896 for hackers-outgoing; Wed, 7 Feb 1996 00:26:14 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id AAA09778 for ; Wed, 7 Feb 1996 00:24:02 -0800 (PST) Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id JAA16554; Wed, 7 Feb 1996 09:21:22 +0100 Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP id JAA00646; Wed, 7 Feb 1996 09:21:17 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.7.3/8.6.9) id JAA04661; Wed, 7 Feb 1996 09:07:44 +0100 (MET) From: J Wunsch Message-Id: <199602070807.JAA04661@uriah.heep.sax.de> Subject: Re: assertions To: swise@austin.ibm.com (Jean-Steveau Wise) Date: Wed, 7 Feb 1996 09:07:43 +0100 (MET) Cc: freebsd-hackers@freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <9602062101.AA30435@vikings.austin.ibm.com> from "Jean-Steveau Wise" at Feb 6, 96 03:01:43 pm X-Phone: +49-351-2012 669 X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-hackers@freebsd.org Precedence: bulk As Jean-Steveau Wise wrote: > > I want to put assertions into the ATAPI driver code and the kernel to > assert that the ATAPI code doesn't leave a system call or interrupt > with interrupts disabled. Can anyone help me code this assertion? My It doesn't look that it would completely disable interrupts, from a quick glance over the code. One oddity that caught my eye: wcd_strategy() finally calls wcd_start(), still at splbio. wcd_start() in turn branches to atapi_request_wait(), which is enbracketed in a pair of splbio/splx. I wouldn't expect this to hang the system, but it looks strange. Have you turned on the atapi debug information? It seems to print lotsa stuff with debug on. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)