From owner-freebsd-current@FreeBSD.ORG Sat Nov 15 19:11:02 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4DFE41065673 for ; Sat, 15 Nov 2008 19:11:02 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.29]) by mx1.freebsd.org (Postfix) with ESMTP id F2FCB8FC12 for ; Sat, 15 Nov 2008 19:11:01 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so800441ywe.13 for ; Sat, 15 Nov 2008 11:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Pzkv24Ohea4fwgUNRRyfDG73elRpVix0SXNOqmLpLkA=; b=nkCPgDe6O6zoprKyPezc8NsS6/y5p9KqZ/35Y/PPBvRuv10CzVvIKNSGLrXa0h00eX GPkRaQgGKpNFroY6OJxYxOR1iq5yOJ6JZGEhKICxaxYpFF8bqeQ+osee9SYBiHiJpmXn bxwgAkgaYOh522s6vqpkiSZMqEb1gh91nLCf4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=bRa31tDWGNbQTK3Fr9RvANEuzSpQz0EwDhA7YrwnMJGJ3rQFNmT90GjzPOnXUsJZl+ tCTBcWv14dBCF05tQZAWmBJC3qxuTDmvX11rvHFWQsU8djg75/XxaNmkC1ng7J0NrAe9 Zdt3a0LVWUP+OBqIBT+7MFvGzyvNWA1PK/Oow= Received: by 10.90.98.12 with SMTP id v12mr1632563agb.64.1226774609905; Sat, 15 Nov 2008 10:43:29 -0800 (PST) Received: by 10.90.101.20 with HTTP; Sat, 15 Nov 2008 10:43:29 -0800 (PST) Message-ID: <790a9fff0811151043l5544194bn9c12f130292e0a6e@mail.gmail.com> Date: Sat, 15 Nov 2008 12:43:29 -0600 From: "Scot Hetzel" To: "Pankov Pavel" In-Reply-To: <491EFFAF.2040700@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <491EFFAF.2040700@mail.ru> Cc: current@freebsd.org Subject: Re: [PATCH] #endif comment fixes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Nov 2008 19:11:02 -0000 On 11/15/08, Pankov Pavel wrote: > Hello. > > According to style(9), there can be a comment added to #endif, telling > the reader about the corresponding #if* condition. This information > isn't used by any program; it's just to save some time for humans, > reading the code. And, as it isn't checked, these comments have > accumulated many errors. Mainly, it's typos, copy-paste bugs, and file > rename leftovers. I have prepared a patch to fix some of them in the > tree. I clearly understand that the patch cannot be committed as is, > because of touched files are maintained outside of FreeBSD source tree. > But maybe respective maintainers will be able to review my patch and > commit or submit fixes upstream. CVS diff against -CURRENT is available > from > http://files.pankov.pp.ru/freebsd/endif-comments-fix.diff.bz2 > (~ 14 The change to mcore.h is wrong, while it makes the #endif comment match the #ifdef and #define at the top of the file, the #ifdef and #define are misspelled: -- contrib/binutils/include/elf/mcore.h 26 Jun 2001 16:57:18 -0000 1.1.1.3 +++ contrib/binutils/include/elf/mcore.h 15 Nov 2008 15:32:30 -0000 @@ -43,4 +43,4 @@ /* Section Attributes. */ #define SHF_MCORE_NOREAD 0x80000000 -#endif /* _ELF_MCORE_H */ +#endif /* _ELF_MORE_H */ Scot