From owner-freebsd-hackers@freebsd.org Mon Oct 15 19:42:53 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4346E10C6F55 for ; Mon, 15 Oct 2018 19:42:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x12d.google.com (mail-it1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B59E982273 for ; Mon, 15 Oct 2018 19:42:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x12d.google.com with SMTP id i191-v6so29307183iti.5 for ; Mon, 15 Oct 2018 12:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=Ot66AOUJdGmE100VLodY/oOsJ6BbUnxlbNmFdC68FQQ=; b=rwxZgehWJ/Qm7ODbQCRcgbrWkrEWxvmg1QS9ZOQCyJ8OJ6JpiE6YG9f+YpVCPOFlMP WxAYjvv3tY3ygY3C/esLnmkrjpc3Qw2kOcMbAWwNqP0KDQzZxeSbo/YrpTXqQGlzPWDl iAulbFUkfDIu3ujFUbAlQk7fXgIOOVrqc1zOXMBKYh977BQZwvhhbJczmUdyuvPhn2/R C2ISTjgCczlivrrejaZTI0XYPJ5oLh7eVMKOJk2xua06vCHmpmoZwQnYS5jdtAC8bnLB QC77/rA28nAMMGrakrNTmAwuAOB6VJZAiJEcSsoV9CskaXBdhh8fC2s7hWa0h/jaodVm d0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :mime-version:content-disposition:user-agent; bh=Ot66AOUJdGmE100VLodY/oOsJ6BbUnxlbNmFdC68FQQ=; b=MTRGFWIl2xv01L0Wtk7qxMfVP8+lJKmX6upFYeTRHFdDqeceoTCE0wiEoj2LAoGZIs cJ27PXkThiDzY6+tjOchc72FN5Dkxiq0XsLjMMCsbcO+B6HyeenWdcFIhgFpM2gyBtNG aUqx4q5k4KgvfITCaS5vcfh2PWtmXuKeU3OuTnGvvMYaFRFyVo1ngsBXjjLYpTh/n7WF Gj9NKJ8CqBfkzMSmmwdDnLdtBtnl90qbyMTUFhU4HmX954M/5h4moxTbECsXa814RBJr fkS+ckXOubLnToHYsOOTDZt6X5lYzbWY84qmA9AexTKWM4pKrK+9NR1HXKcc7IGaAqL4 +KqQ== X-Gm-Message-State: ABuFfojHTge92kKCFV3jnzOXHGikwfJIxwnH6nd1dIL/fG/M6/8Z+Ux7 5oS77nOC6NPUQMLiLEDm+KC/2Anc X-Google-Smtp-Source: ACcGV616Udm08YEU9pQ6JMgt/BTTaKpbcSn4b2FMnkkxIUORVqrlM/ACo9tFMOpNQggbXo/K3igBIw== X-Received: by 2002:a24:16ca:: with SMTP id a193-v6mr13771306ita.134.1539632571827; Mon, 15 Oct 2018 12:42:51 -0700 (PDT) Received: from spy (ip-24-50-182-247.user.start.ca. [24.50.182.247]) by smtp.gmail.com with ESMTPSA id p136-v6sm5282444itb.37.2018.10.15.12.42.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Oct 2018 12:42:51 -0700 (PDT) Sender: Mark Johnston Date: Mon, 15 Oct 2018 15:42:45 -0400 From: Mark Johnston To: freebsd-hackers@freebsd.org Subject: [CFT] capsicum patches for rtsol(8) and rtsold(8) Message-ID: <20181015194212.GA2751@spy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 19:42:53 -0000 Hi, Last week I spent some time Capsicumizing rtsol(8) and rtsold(8). The code for these programs is relatively straightforward, and seems like an ideal candidate for sandboxing given that it parses ND6 RAs while running with privileges (which has led to one SA in the past). I currently don't run rtsold as my home ISP only gives me an IPv4 address. I did a fair amount of testing on an internal network and used packet captures to verify everything, but I was hoping that some folks who actually rely on rtsol(d) would be willing to test the patch before I try to get it reviewed. The patch is here: https://people.freebsd.org/~markj/patches/rtsold_capsicum.diff and a review and description for the capsicum portions is here, if anyone is interested: https://reviews.freebsd.org/D17572 The patch is a superset of the review contents; it contains some unrelated fixes (for e.g., Coverity bugs) and cleanups. To test the patch, apply it, rebuild sbin/rtsol and usr.sbin/rtsold, and restart rtsold. It would be helpful to restart networking at this point, or simply reboot. If the patch works properly, you shouldn't notice any changes in behaviour. I'd be particularly interested in hearing reports from anyone that uses -m or -O, or who depends upon the processing of the RDNSS and DNSSL RA options.