Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jan 2017 03:10:20 +0000 (UTC)
From:      jbeich@freebsd.org (Jan Beich)
To:        grembo@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r432801 - head/devel/ice/files
Message-ID:  <20170130031020.D93951DDC@freefall.freebsd.org>
In-Reply-To: <201701292139.v0TLdUOj092094@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Michael Gmelin <grembo@FreeBSD.org> writes:

> Author: grembo
> Date: Sun Jan 29 21:39:30 2017
> New Revision: 432801
> URL: https://svnweb.freebsd.org/changeset/ports/432801
>
> Log:
>   Allow building devel/py-ice with clang 4.0, based on bug report
>   
>   Tested that this still builds fine using previous versions of clang,
>   didn't bump revision, as there is no functional change and it's
>   a build time error.
[...]
> +-                if(PyTuple_SET_ITEM(results.get(), info->pos, Unset) < 0)
> ++                if(PyTuple_SetItem(results.get(), info->pos, Unset) < 0)

PORTREVISION bump here is required to pick up a regular bugfix. A pointer address
cannot be less than zero unless you cast to a smaller signed type then overflow.

Can you also MFH it to /branches/2017Q1 ?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170130031020.D93951DDC>