Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 05 Jul 2012 13:32:23 -0700
From:      Cy Schubert <Cy.Schubert@komquats.com>
To:        Chris Rees <utisoft@gmail.com>
Cc:        cvs-all@freebsd.org, ports-committers@freebsd.org, Cy Schubert <cy@freebsd.org>, Cy Schubert <Cy.Schubert@komquats.com>, "cvs-ports@FreeBSD.org" <cvs-ports@freebsd.org>, czanik@balabit.hu
Subject:   Re: cvs commit: ports/sysutils/syslog-ng-devel Makefile distinfo  pkg-plist
Message-ID:  <201207052032.q65KWNgr015185@slippy.cwsent.com>
In-Reply-To: Message from Chris Rees <utisoft@gmail.com> of "Thu, 05 Jul 2012 09:15:07 BST." <CADLo839oj_VuLrEPM0dKLHw3tHhkvZR2tVwLHE%2BZd03Mh=fFcQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <CADLo839oj_VuLrEPM0dKLHw3tHhkvZR2tVwLHE+Zd03Mh=fFcQ@mail.gmail.c
om>
, Chris Rees writes:
> --0015175cf764ea820104c410beb6
> Content-Type: text/plain; charset=ISO-8859-1
> 
> On Jul 5, 2012 2:30 AM, "Cy Schubert" <Cy.Schubert@komquats.com> wrote:
> >
> > In message
> <CADLo83-EVdah8Fy4dMOhjNPUPoxfGKnamwLBG=tvVS_RkQEVWw@mail.gmail.c
> > om>
> > , Chris Rees writes:
> > > --0015175df1fcac14a304c4070391
> > > Content-Type: text/plain; charset=ISO-8859-1
> > >
> > > On Jul 4, 2012 8:57 PM, "Cy Schubert" <cy@freebsd.org> wrote:
> > > >
> > > > cy          2012-07-04 19:57:19 UTC
> > > >
> > > >   FreeBSD ports repository
> > > >
> > > >   Modified files:
> > > >     sysutils/syslog-ng-devel Makefile distinfo pkg-plist
> > > >   Log:
> > > >   Update from alpha2 to alpha3.
> > > >
> > > >   Fix Makefile error from r1.57.
> > > >
> > > >   Point to libnet116 instead of defunct libnet115.
> > > >
> > > >   Submitted by:   Update submitted by our upline
> > > >                   (Peter Czanik <czanik@balabit.hu>)
> > >
> > > The PORTVERSION is invalid for this port; having alphabetical
> characters is
> > > not allowed in the same part as digits; instead of 3.4.0a3 you should
> have
> > > 3.4.0.a.3.
> > >
> > > You don't need to do it manually, change PORTVERSION to DISTVERSION and
> > > bsd.port.mk will sort it for you.
> > >
> > > Don't forget to check that the new version is numerically greater
> > > (pkg_version -t)
> > >
> >
> > Thanks Chris.
> >
> > Unfortunately bsd.port.mk comes up with 3.4.0.a3. This is probably not
> what
> > we want.
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /home/pcvs/ports/sysutils/syslog-ng-devel/Makefile,v
> > retrieving revision 1.59
> > diff -u -r1.59 Makefile
> > --- Makefile    4 Jul 2012 19:57:19 -0000       1.59
> > +++ Makefile    5 Jul 2012 01:26:02 -0000
> > @@ -6,10 +6,10 @@
> >  #
> >
> >  PORTNAME=      syslog-ng
> > -PORTVERSION=   3.4.0a3
> > +DISTVERSION=   3.4.0alpha3
> > +PORTEPOCH=     1
> >  CATEGORIES=    sysutils
> >  PKGNAMESUFFIX= -devel
> > -DISTVERSION=   $(PORTVERSION:S/a/alpha/)
> >  DISTFILES=     $(PORTNAME)_$(DISTVERSION).tar.gz
> >  MASTER_SITES=
> http://www.balabit.com/downloads/files/syslog-ng/sources/$(DI
> > STVERSION)/source/
> 
> Ah... perhaps we'd better leave it until a release then- bumping epoch is
> perhaps not a good replacement. :(

Agreed, however the code in bsd.port.mk is buggy. Shouldn't 3.4.0alpha3 be 
3.4.0.a.3, not 3.4.0.a3?


-- 
Cheers,
Cy Schubert <Cy.Schubert@komquats.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207052032.q65KWNgr015185>