From owner-svn-src-all@freebsd.org Tue Jan 29 16:32:55 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04C1C14C2C2F;
Tue, 29 Jan 2019 16:32:55 +0000 (UTC)
(envelope-from yaneurabeya@gmail.com)
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com
[IPv6:2607:f8b0:4864:20::435])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 6785D8DFE2;
Tue, 29 Jan 2019 16:32:54 +0000 (UTC)
(envelope-from yaneurabeya@gmail.com)
Received: by mail-pf1-x435.google.com with SMTP id 64so9887070pfr.9;
Tue, 29 Jan 2019 08:32:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:subject:from:in-reply-to:date:cc
:content-transfer-encoding:message-id:references:to;
bh=XCl6F1BQVQFSNDbx3lMhYp7ZDfnKATPB1wv5xLLNN9w=;
b=GWSRULKJZoX54zCuFALhHbSNywntovadhVHkCL0vuxFzkx+CsskbfXdXSIy1Wkdx4h
BrdJwCvjDH7lL+TV1+gb9KaJOI/ishQTKB02Tfarh47Jry0AoFoOm0nPTMyRzxHDzHTV
kNEvJ17zESLJt409oD4FmDzlLPIk7g2SMRvqmjlenTsoNzHVwl2Ct/+sMDAoZOptcNIP
OzgaeRvKf9mrS93S4rTqIH4IFcevOP46QKOPGoFicDh7FaXfkUZUEHkMk/zDacdfWgbh
jcjPjFGmJCOCe8DwjEhKaw28aeGPlukTX08kGSDeq2d2Hj/z0ztZ2qj3TKXNsQpj71o6
W5Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
:content-transfer-encoding:message-id:references:to;
bh=XCl6F1BQVQFSNDbx3lMhYp7ZDfnKATPB1wv5xLLNN9w=;
b=l70HiWNZkhVgxIV91VKqqR03aE9yE41s8OjMtL3ALS4XraN9j6txzJi9CG4m5vjAga
TyDWDIgEJ4b+yoOd3GLTErgratEzOrxV2PedS5HIdiSni0wpiYZUCc252Dc8j0BYzi5M
UVos+xucCuOiLs2oIknx/AA7sxVIwiXxUQZeQ4kMIEHwRjBKSZhcCJi6synYwwkKeWry
Wp0cQ05HAVmcos4f+AyCVb6znqbdt18KdyjCa3+fHtxVWkmGq1Q2u+CHcjkiUvYUKNEu
P/Tkb0sJN1yLs76wKBQJqyIRJ4ARRli5/mzPn592Beeq18M0S/a3Fg91VJ+iygjLLGeO
uNpw==
X-Gm-Message-State: AJcUukeuJ9F1EkHkYXQ2Hmmp8asrA9mSXbw4atXN5hsWyyFEMD/dj4Qk
BWhLwan3QWfqFSrRgtwBFFMKAkwU
X-Google-Smtp-Source: ALg8bN7TDicPC04fh5JxGSSgb/emOZmq9LdBnx1seSIZKwlYUnrMxI6TG8LOEJaCDvGq7HgwbVDNOg==
X-Received: by 2002:a63:e001:: with SMTP id e1mr18079879pgh.39.1548779572736;
Tue, 29 Jan 2019 08:32:52 -0800 (PST)
Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net.
[73.19.52.228])
by smtp.gmail.com with ESMTPSA id b68sm50796913pfg.160.2019.01.29.08.32.51
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 29 Jan 2019 08:32:52 -0800 (PST)
Content-Type: text/plain;
charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r343543 - head/sbin/bectl/tests
From: Enji Cooper <yaneurabeya@gmail.com>
X-Mailer: iPhone Mail (16C104)
In-Reply-To: <CACNAnaEmeQLwB+a8KWyqB3GFWDn7on4gYtDrH7i5G6mj3zfSJw@mail.gmail.com>
Date: Tue, 29 Jan 2019 08:32:51 -0800
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com>
References: <201901290408.x0T48oJQ080243@repo.freebsd.org>
<CACNAnaEmeQLwB+a8KWyqB3GFWDn7on4gYtDrH7i5G6mj3zfSJw@mail.gmail.com>
To: Kyle Evans <kevans@freebsd.org>
X-Rspamd-Queue-Id: 6785D8DFE2
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.97 / 15.00];
NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
NEURAL_HAM_SHORT(-0.97)[-0.973,0]; REPLY(-4.00)[];
NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for "
user" and " projects" \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2019 16:32:55 -0000
> On Jan 28, 2019, at 20:10, Kyle Evans <kevans@freebsd.org> wrote:
>=20
>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans <kevans@freebsd.org> wrote:
>>=20
>> Author: kevans
>> Date: Tue Jan 29 04:08:49 2019
>> New Revision: 343543
>> URL: https://svnweb.freebsd.org/changeset/base/343543
>>=20
>> Log:
>> bectl(8) test: Force destroy the zpool in cleanup
>>=20
>> This is a wild guess as to why bectl tests failed once upon a time in CI=
,
>> given no apparent way to see a transcript of cleanup routines with Kyua.=
The
>> bectl tests construct a new, clean zpool for every test. The failure
>> indicated was because of a mount that was leftover from a previous test,=
but
>> the previous test had succeeded so it's not clear how the mount remained=
>> leftover unless the `zpool get health ${pool}` had somehow failed.
>>=20
>=20
> I left out: the tests are supposed to be constructed to clean up any
> mounts that were left over in the course of the test, hence the
> assumption that the failure lies in the cleanup.
Hi Kyle,
The tests use a deterministic zpool name defined locally (not globally), and=
will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succeeds.=
The tests will work the first time (when the zpool doesn=E2=80=99t exist), b=
ut I believe they=E2=80=99re actually introducing nondeterminism by accident=
. I will propose a fix for this.
There=E2=80=99s a way to decipher why things failed from /var/log/messages a=
nd kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t know=
what to look for. Can you please provide a failing ci run?
Cheers,
-Enji=