Date: Tue, 29 Jan 2019 08:32:51 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343543 - head/sbin/bectl/tests Message-ID: <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> In-Reply-To: <CACNAnaEmeQLwB%2Ba8KWyqB3GFWDn7on4gYtDrH7i5G6mj3zfSJw@mail.gmail.com> References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <CACNAnaEmeQLwB%2Ba8KWyqB3GFWDn7on4gYtDrH7i5G6mj3zfSJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 28, 2019, at 20:10, Kyle Evans <kevans@freebsd.org> wrote: >=20 >> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans <kevans@freebsd.org> wrote: >>=20 >> Author: kevans >> Date: Tue Jan 29 04:08:49 2019 >> New Revision: 343543 >> URL: https://svnweb.freebsd.org/changeset/base/343543 >>=20 >> Log: >> bectl(8) test: Force destroy the zpool in cleanup >>=20 >> This is a wild guess as to why bectl tests failed once upon a time in CI= , >> given no apparent way to see a transcript of cleanup routines with Kyua.= The >> bectl tests construct a new, clean zpool for every test. The failure >> indicated was because of a mount that was leftover from a previous test,= but >> the previous test had succeeded so it's not clear how the mount remained= >> leftover unless the `zpool get health ${pool}` had somehow failed. >>=20 >=20 > I left out: the tests are supposed to be constructed to clean up any > mounts that were left over in the course of the test, hence the > assumption that the failure lies in the cleanup. Hi Kyle, The tests use a deterministic zpool name defined locally (not globally), and= will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succeeds.= The tests will work the first time (when the zpool doesn=E2=80=99t exist), b= ut I believe they=E2=80=99re actually introducing nondeterminism by accident= . I will propose a fix for this. There=E2=80=99s a way to decipher why things failed from /var/log/messages a= nd kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t know= what to look for. Can you please provide a failing ci run? Cheers, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD>