From owner-svn-src-all@FreeBSD.ORG  Wed May 13 17:25:40 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8398106566C;
	Wed, 13 May 2009 17:25:40 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 87AD28FC17;
	Wed, 13 May 2009 17:25:40 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id AE556FF47;
	Thu, 14 May 2009 05:25:39 +1200 (NZST)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id x8T5Jv35q55l; Thu, 14 May 2009 05:25:35 +1200 (NZST)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Thu, 14 May 2009 05:25:35 +1200 (NZST)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id 18B9F11432; Thu, 14 May 2009 05:25:35 +1200 (NZST)
Date: Wed, 13 May 2009 10:25:34 -0700
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Dimitry Andric <dimitry@andric.com>
Message-ID: <20090513172534.GA2537@citylink.fud.org.nz>
References: <200905120741.n4C7fK8o014803@svn.freebsd.org>
	<4A09B57C.6050709@andric.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A09B57C.6050709@andric.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: svn-src-head@freebsd.org, Qing Li <qingli@FreeBSD.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r192011 - head/sys/netinet
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2009 17:25:41 -0000

On Tue, May 12, 2009 at 07:44:28PM +0200, Dimitry Andric wrote:
> On 2009-05-12 09:41, Qing Li wrote:
> > Author: qingli
> > Date: Tue May 12 07:41:20 2009
> > New Revision: 192011
> > URL: http://svn.freebsd.org/changeset/base/192011
> > 
> > Log:
> >   This patch adds a host route to an interface address (that is assigned
> >   to a non loopback/ppp link types) through the loopback interface. Prior
> >   to the new L2/L3 rewrite, this host route is implicitly added by the L2
> >   code during RTM_RESOLVE of that interface address. This host route is
> >   deleted when that interface is removed.
> 
> This commit breaks dhclient startup, I now get:
> 
> [...]
> in_ifinit: insertion failed
> ifconfig: ioctl (SIOCAIFADDR): File exists
> em0: not found
> exiting.
> 
> So it seems to hit this part:
> 
> +		} else if (error != 0)
> +			log(LOG_INFO, "in_ifinit: insertion failed\n");
> 
> Reverting the commit makes dhclient work again.

It also breaks PXE booting, can it be fixed or reverted?

bootpc_init: wired to interface 'npe0'
in_ifinit: insertion failed
panic: bootpc_fakeup_interface: set if addr, error=17


Andrew