From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 9 14:10:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D527D1065670 for ; Sun, 9 Mar 2008 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AAD5C8FC2E for ; Sun, 9 Mar 2008 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m29EA1WA079712 for ; Sun, 9 Mar 2008 14:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m29EA1Tp079711; Sun, 9 Mar 2008 14:10:01 GMT (envelope-from gnats) Resent-Date: Sun, 9 Mar 2008 14:10:01 GMT Resent-Message-Id: <200803091410.m29EA1Tp079711@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ighighi Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 332B31065670 for ; Sun, 9 Mar 2008 14:03:26 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 1A27D8FC1E for ; Sun, 9 Mar 2008 14:03:26 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m29E0GXe064796 for ; Sun, 9 Mar 2008 14:00:16 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m29E0GAD064795; Sun, 9 Mar 2008 14:00:16 GMT (envelope-from nobody) Message-Id: <200803091400.m29E0GAD064795@www.freebsd.org> Date: Sun, 9 Mar 2008 14:00:16 GMT From: Ighighi To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/121520: [patch]: support for multiple arguments for dirname(1) just as basename(1) does X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Mar 2008 14:10:01 -0000 >Number: 121520 >Category: bin >Synopsis: [patch]: support for multiple arguments for dirname(1) just as basename(1) does >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Mar 09 14:10:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ighighi >Release: 6.3-STABLE >Organization: >Environment: FreeBSD orion 6.3-STABLE FreeBSD 6.3-STABLE #0: Mon Mar 3 04:45:31 VET 2008 root@orion:/usr/obj/usr/src/sys/CUSTOM i386 >Description: This patch adds support for multiple arguments to dirname(1) like basename(1) has been already. It's the natural thing to expect, both commands even share the same manpage. >How-To-Repeat: >Fix: Patch attached with submission follows: # # Note: both basename(1) and dirname(1) use basename(1)'s manpage # --- src/usr.bin/dirname/dirname.c.orig Sat May 21 05:55:05 2005 +++ src/usr.bin/dirname/dirname.c Thu May 3 18:09:12 2007 @@ -66,12 +66,15 @@ argc -= optind; argv += optind; - if (argc != 1) + if (argc < 1) usage(); - if ((p = dirname(*argv)) == NULL) - err(1, "%s", *argv); - (void)printf("%s\n", p); + while (argc--) { + if ((p = dirname(*argv)) == NULL) + err(1, "%s", *argv); + argv++; + (void)printf("%s\n", p); + } exit(0); } @@ -79,6 +82,6 @@ usage(void) { - (void)fprintf(stderr, "usage: dirname string\n"); + (void)fprintf(stderr, "usage: dirname string [...]\n"); exit(1); } --- src/usr.bin/basename/basename.1.orig Tue Jan 18 09:43:47 2005 +++ src/usr.bin/basename/basename.1 Thu May 3 18:28:27 2007 @@ -52,6 +52,7 @@ .Op Ar ... .Nm dirname .Ar string +.Op Ar ... .Sh DESCRIPTION The .Nm >Release-Note: >Audit-Trail: >Unformatted: