From owner-cvs-all Mon Oct 28 19:24:54 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E8E837B401; Mon, 28 Oct 2002 19:24:53 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C4C943E42; Mon, 28 Oct 2002 19:24:52 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id g9T3OqnQ037230; Mon, 28 Oct 2002 19:24:52 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.5/Submit) id g9T3Nb1R037168; Mon, 28 Oct 2002 19:23:37 -0800 (PST) Date: Mon, 28 Oct 2002 19:23:37 -0800 From: "David O'Brien" To: Juli Mallett Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile job.c nonints.h str.c var.c var.h var_modify.c Message-ID: <20021029032337.GB36927@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Juli Mallett , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200210282333.g9SNXvvt039931@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200210282333.g9SNXvvt039931@repoman.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Oct 28, 2002 at 03:33:57PM -0800, Juli Mallett wrote: > jmallett 2002/10/28 15:33:57 PST > > Modified files: > usr.bin/make Makefile job.c nonints.h str.c var.c > Added files: > usr.bin/make var.h var_modify.c > Log: > Split var.c into var.c and var_modify.c and move all the modification funcs > to var_modify.c, for readability. constify some low hanging fruit (string > manipulation functions) and the upper layers appropriately. No longer use > the private strstr(3) implementation, while changing string code. Are you willing to name this varmodifiers.c and organize it simular to what OpenBSD has done? It would certainly help notice bugs fixed in their code base. Or leave things as-is to make it easier to notice bugs fixed in NetBSD? We don't need so much divergence in what once was a 100% common code base. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message