From owner-cvs-src@FreeBSD.ORG  Thu Jul 31 09:19:08 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A23D937B401; Thu, 31 Jul 2003 09:19:08 -0700 (PDT)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C59CC43FDF; Thu, 31 Jul 2003 09:19:05 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h6VGJ5QX089589;
	Thu, 31 Jul 2003 09:19:05 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h6VGJ59N089588;
	Thu, 31 Jul 2003 09:19:05 -0700 (PDT)
Date: Thu, 31 Jul 2003 09:19:05 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: Ruslan Ermilov <ru@FreeBSD.org>, cvs-all@FreeBSD.org,
	cvs-src@FreeBSD.org, src-committers@FreeBSD.org
Message-ID: <20030731161905.GB69708@dragon.nuxi.com>
References: <200307250855.h6P8tpCr098669@repoman.freebsd.org>
	<XFMail.20030730153503.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <XFMail.20030730153503.jhb@FreeBSD.org>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 5.1-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Subject: Re: cvs commit: src/release Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2003 16:19:09 -0000

On Wed, Jul 30, 2003 at 03:35:03PM -0400, John Baldwin wrote:
> 
> On 25-Jul-2003 Ruslan Ermilov wrote:
> > ru          2003/07/25 01:55:51 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     release              Makefile 
> >   Log:
> >   The RELEASE9 knob is now OBE.
> >   
> >   OK'ed by:       jhb
> 
> No, it is _not_ ok'd.  You committed this before I had reviewed
> the actual patch and not in the manner I had stated.  Please
> have more patience.

Yes RU.

"make release.9" should build all the "floppies" and related bits.
W/in release/Makefile there should be this rule:

    release.9: release.9.${TARGET_ARCH}

for convieance sake.  'release.10' would build the BOOTMFS kernel.
'release.11' would make the cdrom boot image (ie, the "huge" flopy).
'release.12' would make say the driver floppy.

Then each release.9.${TARGET_ARCH} target should issue "${MAKE}
release.10 FDSIZE=<propersize>", those needing a driver floppy would
issue ""${MAKE} release.12 <KNOB>=<proper value>", etc...

Think C -- small subroutines w/o #ifdef's are good.

-- 
-- David  (obrien@FreeBSD.org)