Date: Thu, 11 Feb 2021 12:47:03 -0600 From: Kyle Evans <kevans@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: Ravi Pokala <rpokala@freebsd.org>, "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: Including IB utils in install images Message-ID: <CACNAnaG%2BX5Hqsy4yds3xyYQbDwW8N8tq3r-119y2Mo=RHRJfGA@mail.gmail.com> In-Reply-To: <20210203182928.GG77557@FreeBSD.org> References: <377FA5D1-0DC8-463D-A8E3-5645801C2858@freebsd.org> <20210203182928.GG77557@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 3, 2021 at 12:29 PM Glen Barber <gjb@freebsd.org> wrote: > > On Wed, Feb 03, 2021 at 10:06:20AM -0800, Ravi Pokala wrote: > > Hi folks, > > > > I'm using release/release.sh to create install images. We recently dete= rmined that we need to start including the InfiniBand utilities (contrib/of= ed/infiniband-diags / usr.bin/ofed/infiniband-diags). I updated my release.= conf to add 'WITH_OFED_EXTRA=3D1' to MAKE_FLAGS, and I confirmed that the u= tilities are being built. However, they are not subsequently copied to the = distdir, or included in the resulting image. Well, technically, `ibstat' is= , but per usr.bin/ofed/infiniband-diags/Makefile, it is not contingent on W= ITH_OFED_EXTRA / MK_OFED_EXTRA. > > > > Bug, or operator error? > > > > You could set a local SRC_CONF (see release/release.conf.sample), but > I *think* you also need to set WITH_OFED=3D1. According to src.conf(5), > it seems WITH_OFED_EXTRA is ignored unless WITH_OFED is explicitly set. > Ravi followed up privately here; the problem he was seeing is because MAKE_FLAGS is only included in release.sh for building stuff. WORLD_FLAGS gets closer to what he wants, but a local src.conf is better as far as "touching build options" goes. The caveat was that then they'd have to pair their release.conf with a src.conf; I pointed out that release.conf is literally sourced in and that's heavily baked in enough to release.sh that it cannot change. A good solution for this kind of thing should be something along the lines of: srcconf=3D/path/whatever/maybe/tmpfile cat <<EOF > $srcconf WITH_OFED_EXTRA=3D"YES" EOF ... SRC_CONF=3D$srcconf Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaG%2BX5Hqsy4yds3xyYQbDwW8N8tq3r-119y2Mo=RHRJfGA>