From owner-freebsd-testing@FreeBSD.ORG Wed Apr 2 18:47:09 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B243CECE; Wed, 2 Apr 2014 18:47:09 +0000 (UTC) Received: from mail-vc0-x22a.google.com (mail-vc0-x22a.google.com [IPv6:2607:f8b0:400c:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5EDA0A7A; Wed, 2 Apr 2014 18:47:09 +0000 (UTC) Received: by mail-vc0-f170.google.com with SMTP id hu19so941137vcb.1 for ; Wed, 02 Apr 2014 11:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iLyF8+46Sq7YVLVB5LG9B6UkivZHRV4lfAqyNP2vQZk=; b=tPRuTjBvvajAJjO5SNrNsc4wfzXLxMkqi11lVmuDce2ehj2fwUaljniE8rqrnd1sI9 V5Bjz0+eywjZMjRr/oEKBIoWImCi2Jfx/9bDd+RaqPyKDU6ObMKy+YScZMyawJBjynJ2 uTy/SnczIHEdfknzjWvjG7v00573egfJQr8nDvVBS+JncHMyq3kViAzDiM+B1YG8GcVC pNoIa6WuEOPnk2cjeepaY/WDs+YaohmREPGghVik+v+oJXnglugVh7iBNMqX/8z1o8FH 5Ju6SchfT1QCRIEUvfxE+GraKlBdMtQEJ3RpPAETBPTNVrmN4PbvYLFy0Qn7+bCjT7vp F8fA== MIME-Version: 1.0 X-Received: by 10.52.119.178 with SMTP id kv18mr2317379vdb.39.1396464428434; Wed, 02 Apr 2014 11:47:08 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Wed, 2 Apr 2014 11:47:08 -0700 (PDT) In-Reply-To: References: <20140402085349.GA61802@x2.osted.lan> Date: Wed, 2 Apr 2014 11:47:08 -0700 Message-ID: Subject: Re: ATF work From: Garrett Cooper To: Craig Rodrigues Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 18:47:09 -0000 On Wed, Apr 2, 2014 at 10:21 AM, Craig Rodrigues wrote: > On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers wrote: >> On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm wrote: >>> I have uploaded a snapshot of the ATF work done for EMC Isilon, >>> based primarily on Garrett Cooper's work. >>> >>> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz >>> + >>> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr >> >> Holy patch queue, Batman! There's fifty thousand lines of code in here! > > > When a patch is that big, it becomes very difficult to review. > > You might want to consider forking a copy on github of the > https://github.com/freebsd/freebsd repository and maintaining the patch there > until it is MFC'd: > > https://help.github.com/articles/fork-a-repo > https://help.github.com/articles/syncing-a-fork > > It's not perfect but some of the web interface tools around the github > ecosystem make reviewing patches (and contributing updates) a bit easier. I was going to move master aside and make all of the ATF work into its own separate branch again as my fork's master still contains little tidbits of other fixes and hacks that I made to make things work on my system(s). When I originally did this on my fork I was dealing with a lot more branches (nowadays I mostly maintain my fork instead of develop/port new code). It might be easiest to move forward if pho forks my repo once it's been cleaned up, and the Isilon patches to my code get integrated into my fork as a GitHub pull request. I'll start working on that today and will talk with pho@ offline about getting things all herded together properly. Thanks! -Garrett