From owner-freebsd-hackers@FreeBSD.ORG Thu Jul 12 19:47:06 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F28E106566B; Thu, 12 Jul 2012 19:47:06 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from mail.averesystems.com (50-73-27-109-cpennsylvania.hfc.comcastbusiness.net [50.73.27.109]) by mx1.freebsd.org (Postfix) with ESMTP id 526548FC15; Thu, 12 Jul 2012 19:47:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.averesystems.com (Postfix) with ESMTP id 910244806DD; Thu, 12 Jul 2012 15:47:09 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.averesystems.com Received: from mail.averesystems.com ([127.0.0.1]) by localhost (mail.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bfkVCR-tv5hO; Thu, 12 Jul 2012 15:47:08 -0400 (EDT) Received: from riven.arriad.com (206.193.225.214.nauticom.net [206.193.225.214]) by mail.averesystems.com (Postfix) with ESMTPSA id B42FF4806CA; Thu, 12 Jul 2012 15:47:08 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=iso-8859-1 From: Andrew Boyer In-Reply-To: <4FFF27F0.4000106@FreeBSD.org> Date: Thu, 12 Jul 2012 15:47:03 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <742407DF-8026-4976-A1F9-A170A62EF87A@averesystems.com> References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> <4FFB4770.7050209@FreeBSD.org> <20120710154128.192eb8d6@fabiankeil.de> <1341939155.2573.8.camel@powernoodle.corp.yahoo.com> <20120710205702.5e57168b@fabiankeil.de> <4FFC8479.9080608@FreeBSD.org> <20120711122935.1382e76d@fabiankeil.de> <20120712201741.34573af4@fabiankeil.de> <4FFF2171.1030800@FreeBSD.org> <20120712213615.39640d1f@fabiankeil.de> <4FFF27F0.4000106@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.1278) Cc: freebsd-hackers@FreeBSD.org, Sean Bruno , Fabian Keil Subject: Re: dtraceall.ko with old nfsclient X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 19:47:06 -0000 On Jul 12, 2012, at 3:39 PM, Andriy Gapon wrote: > on 12/07/2012 22:36 Fabian Keil said the following: >> Andriy Gapon wrote: >>=20 >>> on 12/07/2012 21:17 Fabian Keil said the following: >>>> Benjamin Kaduk wrote: >>>>=20 >>>>> On Wed, 11 Jul 2012, Fabian Keil wrote: >>>>>=20 >>>>>> I'm using the following modification of Sean's patch: >>>>=20 >>>> This way it seems to work as expected: >>>>=20 >>>> diff --git a/sys/modules/dtrace/dtraceall/Makefile=20 >>>> b/sys/modules/dtrace/dtraceall/Makefile index 456efd1..628583b = 100644 >>>> --- a/sys/modules/dtrace/dtraceall/Makefile +++=20 >>>> b/sys/modules/dtrace/dtraceall/Makefile @@ -1,7 +1,7 @@ # $FreeBSD:=20= >>>> src/sys/modules/dtrace/dtraceall/Makefile,v 1.3 2011/04/09 09:07:31 = uqs >>>> Exp $ >>>>=20 >>>> KMOD=3D dtraceall -SRCS=3D dtraceall.c = opt_compat.h >>>> +SRCS=3D dtraceall.c opt_compat.h opt_nfs.h >>>>=20 >>>> CFLAGS+=3D -I${.CURDIR}/../../.. >>>>=20 >>>=20 >>> If you do cd sys/modules/dtrace/dtraceall && make [obj depend] all, = does >>> it compile OK with the above change? >>=20 >> Depends on your expectations I guess. As neither NFS-related option = gets >> defined, no dependency on either NFS module is registered. The = compiler has >> no complaints, though. >=20 > Interesting. Could you repeat after sufficient cleaning up? > I am not sure where from opt_nfs.h file could come. >=20 Maybe related: check out sys/modules/ipfw/Makefile. It makes its own = option headers for INET and INET6. -A -------------------------------------------------- Andrew Boyer aboyer@averesystems.com