From owner-freebsd-current Wed Jan 22 6:10: 8 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E5F037B405; Wed, 22 Jan 2003 06:10:07 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0BBF43F13; Wed, 22 Jan 2003 06:10:05 -0800 (PST) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id PAA06087; Wed, 22 Jan 2003 15:10:04 +0100 (CET) Received: from uriah.heep.sax.de (localhost.heep.sax.de [127.0.0.1]) by uriah.heep.sax.de (8.12.6/8.12.6) with ESMTP id h0ME7eRL078594; Wed, 22 Jan 2003 15:07:40 +0100 (MET) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.12.6/8.12.6/Submit) id h0ME7e7A078593; Wed, 22 Jan 2003 15:07:40 +0100 (MET) Date: Wed, 22 Jan 2003 15:07:40 +0100 From: Joerg Wunsch To: phk@freebsd.org Cc: ticso@cicely.de, freebsd-current@freebsd.org Subject: Re: I want a sysctl kern.allow_shooting_into_my_foot! Message-ID: <20030122150740.C70341@uriah.heep.sax.de> Reply-To: Joerg Wunsch Mail-Followup-To: Joerg Wunsch , phk@freebsd.org, ticso@cicely.de, freebsd-current@freebsd.org References: <20030122134820.GD758@cicely8.cicely.de> <25787.1043243590@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <25787.1043243590@critter.freebsd.dk>; from phk@freebsd.org on Wed, Jan 22, 2003 at 02:53:10PM +0100 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG As phk@freebsd.org wrote: > >You are saying that the close should read? > >error = (*devsw(drive->dev)->d_close) (drive->dev, FWRITE | FREAD, 0, NULL); > > Yes, d_close should match whatever the corresponding d_open is called with. Thanks for pointing this out, this indeed seems to fix this case, fix already committed. ;-) -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message