From owner-p4-projects@FreeBSD.ORG Sat Sep 15 19:51:05 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3DEAD16A420; Sat, 15 Sep 2007 19:51:05 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC10B16A419 for ; Sat, 15 Sep 2007 19:51:04 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ADF8D13C468 for ; Sat, 15 Sep 2007 19:51:04 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8FJp4NS098165 for ; Sat, 15 Sep 2007 19:51:04 GMT (envelope-from kmacy@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8FJp4GN098162 for perforce@freebsd.org; Sat, 15 Sep 2007 19:51:04 GMT (envelope-from kmacy@freebsd.org) Date: Sat, 15 Sep 2007 19:51:04 GMT Message-Id: <200709151951.l8FJp4GN098162@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to kmacy@freebsd.org using -f From: Kip Macy To: Perforce Change Reviews Cc: Subject: PERFORCE change 126439 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2007 19:51:05 -0000 http://perforce.freebsd.org/chv.cgi?CH=126439 Change 126439 by kmacy@kmacy_home:ethng on 2007/09/15 19:50:28 make the jumbo phys contig sysctl read only skip call to uma_find_refcnt if the result is not going to be used Affected files ... .. //depot/projects/ethng/src/sys/kern/kern_mbuf.c#5 edit Differences ... ==== //depot/projects/ethng/src/sys/kern/kern_mbuf.c#5 (text+ko) ==== @@ -142,7 +142,7 @@ "Maximum number of mbuf 16k jumbo clusters allowed"); SYSCTL_STRUCT(_kern_ipc, OID_AUTO, mbstat, CTLFLAG_RD, &mbstat, mbstat, "Mbuf general information and statistics"); -SYSCTL_INT(_kern_ipc, OID_AUTO, jumbo_phys_contig, CTLFLAG_RW, &jumbo_phys_contig, 1, +SYSCTL_INT(_kern_ipc, OID_AUTO, jumbo_phys_contig, CTLFLAG_RD, &jumbo_phys_contig, 1, "jumbo frames are physically contiguous"); /* * Zones from which we allocate. @@ -435,10 +435,11 @@ break; } - m = (struct mbuf *)arg; - refcnt = uma_find_refcnt(zone, mem); - *refcnt = 1; - if (m != NULL) { + + if (arg != NULL) { + refcnt = uma_find_refcnt(zone, mem); + *refcnt = 1; + m = (struct mbuf *)arg; m->m_ext.ext_buf = (caddr_t)mem; m->m_data = m->m_ext.ext_buf; m->m_flags |= M_EXT;