From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 5 21:40:03 2013 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CFCBE235; Tue, 5 Feb 2013 21:40:03 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id EBF9299B; Tue, 5 Feb 2013 21:40:02 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED Received: from [176.74.213.204] (account mc467741@c2i.net HELO laptop015.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 375788580; Tue, 05 Feb 2013 22:39:54 +0100 From: Hans Petter Selasky To: edwin@freebsd.org Subject: Re: ports/175860: multimedia/webcamd: expose Wacom via HAL for hotplugging Date: Tue, 5 Feb 2013 22:41:06 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.1-STABLE; KDE/4.8.4; amd64; ; ) References: <201302051200.r15C0DKw030241@freefall.freebsd.org> <201302052030.08377.hselasky@c2i.net> In-Reply-To: <201302052030.08377.hselasky@c2i.net> X-Face: ?p&W)c(+80hU; '{.$5K+zq{oC6y| /D'an*6mw>j'f:eBsex\Gi, Cc: freebsd-ports-bugs@freebsd.org, Juergen Lock , "bug-followup@FreeBSD.org" , Jan Beich X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2013 21:40:03 -0000 --Boundary-00=_yxXERkHGKUmruMn Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit On Tuesday 05 February 2013 20:30:08 Hans Petter Selasky wrote: > On Tuesday 05 February 2013 13:00:13 edwin@freebsd.org wrote: > > Synopsis: multimedia/webcamd: expose Wacom via HAL for hotplugging > > > > Responsible-Changed-From-To: freebsd-ports-bugs->hselasky > > Responsible-Changed-By: edwin > > Responsible-Changed-When: Tue Feb 5 12:00:13 UTC 2013 > > Responsible-Changed-Why: > > Over to maintainer (via the GNATS Auto Assign Tool) > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=175860 > New attached patch updates webcamd 3.9.0.4. 1) xorg-server must be compiled with HAL support. 2) /etc/X11/xorg.conf must contain this: Section "ServerFlags" Option "AutoAddDevices" "true" Option "AutoEnableDevices" "true" Option "AllowEmptyInput" "false" EndSection 3) Restart Xorg and hald --HPS --Boundary-00=_yxXERkHGKUmruMn Content-Type: text/x-patch; charset="iso-8859-15"; name="webcamd-3.9.0.4.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="webcamd-3.9.0.4.diff" Index: webcamd_hal.c =================================================================== --- webcamd_hal.c (revision 2570) +++ webcamd_hal.c (revision 2572) @@ -40,7 +40,7 @@ #ifndef HAVE_HAL void -hal_init(int bus, int addr, int iface) +hal_init(int bus, int addr, int iface, const char *desc) { return; } @@ -61,10 +61,12 @@ static LibHalContext *hal_ctx; static DBusConnection *hal_conn; static char *hal_dev; +static char *hal_desc; +static int hal_iface; static int hal_dvb_index; void -hal_init(int bus, int addr, int iface) +hal_init(int bus, int addr, int iface, const char *desc) { char **ppdev; int n; @@ -77,6 +79,13 @@ printf("Waiting for DBUS connection.\n"); } + if (desc == NULL) + desc = "unknown"; + + hal_desc = strdup(desc); + if (hal_desc == NULL) + return; + hal_ctx = libhal_ctx_new(); if (hal_ctx == NULL) return; @@ -109,6 +118,7 @@ continue; hal_dev = strdup(ppdev[n]); + hal_iface = iface; break; } } @@ -254,6 +264,59 @@ free(pdvb); hal_dvb_index++; + } else if (!strncmp(devname, "input/event", + sizeof("input_event") - 1)) { + + char *pinput = NULL; + char *pnew; + + asprintf(&pinput, "%s_if%d_logicaldev_input", + hal_dev, hal_iface); + + if (pinput == NULL) + return; + + if (libhal_device_exists(hal_ctx, pinput, NULL) == 0) { + pnew = libhal_new_device(hal_ctx, NULL); + if (pnew == NULL) { + free(pinput); + return; + } + } else { + pnew = pinput; + } + + cset = libhal_device_new_changeset(pnew); + if (cset == NULL) { + if (pnew != pinput) + free(pnew); + free(pinput); + } + + libhal_changeset_set_property_string(cset, "info.category", "input"); + libhal_changeset_set_property_string(cset, "info.parent", hal_dev); + libhal_changeset_set_property_string(cset, "info.product", hal_desc); + libhal_changeset_set_property_string(cset, "info.subsystem", "input"); + libhal_changeset_set_property_string(cset, "input.device", devpath); + libhal_changeset_set_property_string(cset, "input.originating_device", hal_dev); + libhal_changeset_set_property_string(cset, "input.product", hal_desc); + if (strcmp(hal_desc, "wacom") == 0) + libhal_changeset_set_property_string(cset, "input.x11_driver", hal_desc); + + libhal_changeset_set_property_string(cset, "linux.device_file", devpath); + libhal_changeset_set_property_int(cset, "linux.hotplug_type", 2); + libhal_changeset_set_property_string(cset, "info.subsystem", "input"); + libhal_changeset_set_property_string(cset, "linux.sysfs_path", devpath); + + libhal_device_add_capability(hal_ctx, pnew, "input", NULL); + libhal_device_commit_changeset(hal_ctx, cset, NULL); + libhal_device_free_changeset(cset); + + if (pnew != pinput) { + libhal_device_commit_to_gdl(hal_ctx, pnew, pinput, NULL); + free(pnew); + } + free(pinput); } } Index: webcamd_hal.h =================================================================== --- webcamd_hal.h (revision 2570) +++ webcamd_hal.h (revision 2572) @@ -26,7 +26,7 @@ #ifndef _WEBCAMD_HAL_H_ #define _WEBCAMD_HAL_H_ -void hal_init(int bus, int addr, int iface); +void hal_init(int bus, int addr, int iface, const char *desc); void hal_add_device(const char *devname); #endif /* _WEBCAMD_HAL_H_ */ Index: kernel/linux_usb.h =================================================================== --- kernel/linux_usb.h (revision 2570) +++ kernel/linux_usb.h (revision 2572) @@ -638,7 +638,7 @@ int usb_deregister(struct usb_driver *drv); struct usb_linux_softc *usb_linux2usb(int fd); -int usb_linux_probe_p(int *p_bus, int *p_addr, int *p_index); +int usb_linux_probe_p(int *p_bus, int *p_addr, int *p_index, const char **ppdesc); int usb_linux_detach(int fd); int usb_linux_suspend(int fd); int usb_linux_resume(int fd); Index: kernel/linux_usb.c =================================================================== --- kernel/linux_usb.c (revision 2570) +++ kernel/linux_usb.c (revision 2572) @@ -282,7 +282,7 @@ * This function is the FreeBSD probe and attach callback. *------------------------------------------------------------------------*/ int -usb_linux_probe_p(int *p_bus, int *p_addr, int *p_index) +usb_linux_probe_p(int *p_bus, int *p_addr, int *p_index, const char **pp_desc) { const struct usb_device_id *id; struct usb_linux_softc *sc; @@ -387,6 +387,7 @@ *p_bus = libusb20_dev_get_bus_number(pdev); *p_addr = libusb20_dev_get_address(pdev); *p_index = index_copy; + *pp_desc = udrv->name; if (pidfile_create(*p_bus, *p_addr, index_copy)) { fprintf(stderr, "Webcamd is already running for " @@ -434,6 +435,9 @@ libusb20_be_dequeue_device(pbe, pdev); libusb20_be_free(pbe); + /* detach kernel driver, if any */ + libusb20_dev_detach_kernel_driver(pdev, i); + return (device_index); } Index: webcamd.c =================================================================== --- webcamd.c (revision 2570) +++ webcamd.c (revision 2572) @@ -94,6 +94,7 @@ static int do_fork = 0; static int do_realtime = 1; static struct pidfh *local_pid = NULL; +static const char *d_desc; static gid_t gid; static uid_t uid; static int gid_found; @@ -707,12 +708,12 @@ linux_init(); if (vtuner_client == 0) { - if (usb_linux_probe_p(&u_unit, &u_addr, &u_index) < 0) + if (usb_linux_probe_p(&u_unit, &u_addr, &u_index, &d_desc) < 0) v4b_errx(1, "Cannot find USB device"); } if (vtuner_server == 0) { if (webcamd_hal_register) - hal_init(u_unit, u_addr, u_index); + hal_init(u_unit, u_addr, u_index, d_desc); v4b_create(u_videodev); --Boundary-00=_yxXERkHGKUmruMn--