From owner-freebsd-bugs@FreeBSD.ORG Thu Dec 2 09:30:18 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 515F016A4CE for ; Thu, 2 Dec 2004 09:30:18 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CE7343D5A for ; Thu, 2 Dec 2004 09:30:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iB29UHXw039396 for ; Thu, 2 Dec 2004 09:30:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iB29UHHR039394; Thu, 2 Dec 2004 09:30:17 GMT (envelope-from gnats) Resent-Date: Thu, 2 Dec 2004 09:30:17 GMT Resent-Message-Id: <200412020930.iB29UHHR039394@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Divacky Roman Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E473316A4CE for ; Thu, 2 Dec 2004 09:25:25 +0000 (GMT) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC79A43D46 for ; Thu, 2 Dec 2004 09:25:24 +0000 (GMT) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (localhost [127.0.0.1]) by eva.fit.vutbr.cz (8.12.11/8.12.11) with ESMTP id iB29PKMh008756 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Thu, 2 Dec 2004 10:25:21 +0100 (CET) Received: (from xdivac02@localhost) by eva.fit.vutbr.cz (8.12.11/8.12.5/Submit) id iB29PKoX008755; Thu, 2 Dec 2004 10:25:20 +0100 (CET) Message-Id: <200412020925.iB29PKoX008755@eva.fit.vutbr.cz> Date: Thu, 2 Dec 2004 10:25:20 +0100 (CET) From: Divacky Roman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/74609: allowing cdma modems to work at full speed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Divacky Roman List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2004 09:30:18 -0000 >Number: 74609 >Category: kern >Synopsis: allowing cdma modems to work at full speed >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Thu Dec 02 09:30:17 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Divacky Roman >Release: FreeBSD 6.0-CURRENT i386 >Organization: home >Environment: FreeBSD queeg500 5.3-RELEASE FreeBSD 5.3-RELEASE #13: Wed Nov 17 17:58:28 CET 2004 rdivacky@queeg500:/usr/obj/usr/src/sys/QUEEG i386 >Description: umodem driver has hardcoded value of packetsize, this prevents cdma modems (for example) to work at full speed. my patch implements packet size as a tunable hence allowing user to set it and this achieve higher speeds. >How-To-Repeat: apply this patch and set hw.usb.umodem.ibufsize="1024" hw.usb.umodem.obufsize="1024" in your /boot/loader.conf and see your cdma modem work at full speed >Fix: --- sys/dev/usb/umodem.c Fri Sep 17 13:53:45 2004 +++ sys/dev/usb/umodem.c Wed Dec 1 18:57:17 2004 @@ -106,9 +106,9 @@ #include "usbdevs.h" +SYSCTL_NODE(_hw_usb, OID_AUTO, umodem, CTLFLAG_RW, 0, "USB umodem"); #ifdef USB_DEBUG int umodemdebug = 0; -SYSCTL_NODE(_hw_usb, OID_AUTO, umodem, CTLFLAG_RW, 0, "USB umodem"); SYSCTL_INT(_hw_usb_umodem, OID_AUTO, debug, CTLFLAG_RW, &umodemdebug, 0, "umodem debug level"); #define DPRINTFN(n, x) if (umodemdebug > (n)) logprintf x @@ -132,8 +132,16 @@ * If some really high speed devices should use this driver they * may need to be increased, but this is good enough for normal modems. */ -#define UMODEMIBUFSIZE 64 -#define UMODEMOBUFSIZE 256 +int umodemibufsize = 64; +int umodemobufsize = 256; +TUNABLE_INT("hw.usb.umodem.ibufsize", &umodemibufsize); +TUNABLE_INT("hw.usb.umodem.obufsize", &umodemobufsize); +SYSCTL_INT(_hw_usb_umodem, OID_AUTO, ibufsize, CTLFLAG_RD, + &umodemibufsize, 0, "umodem input packet length"); +SYSCTL_INT(_hw_usb_umodem, OID_AUTO, obufsize, CTLFLAG_RD, + &umodemobufsize, 0, "umodem output packet length"); +#define UMODEMIBUFSIZE (umodemibufsize) +#define UMODEMOBUFSIZE (umodemobufsize) #define UMODEM_MODVER 1 /* module version */ >Release-Note: >Audit-Trail: >Unformatted: