From owner-svn-src-stable@freebsd.org  Tue Mar  6 17:07:34 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BF45F4369D;
 Tue,  6 Mar 2018 17:07:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1A997806E9;
 Tue,  6 Mar 2018 17:07:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0F0CA16294; Tue,  6 Mar 2018 17:07:34 +0000 (UTC)
Date: Tue, 6 Mar 2018 17:07:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Cc: Eitan Adler <eadler@freebsd.org>, svn-src-stable@freebsd.org,
 svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>,
 svn-src-stable-11@freebsd.org
Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus
 dev/usb/wlan net80211
Message-ID: <20180306170733.GA84985@FreeBSD.org>
References: <201803050754.w257swAE001435@repo.freebsd.org>
 <1861296.ksaTdANMae@ralph.baldwin.cx>
 <CAF6rxgk7v7OecuUWvRrJXg69uez6KmgnmrPtmExC4LmrjA8+Dw@mail.gmail.com>
 <6465173.s2nWvWCLOs@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6465173.s2nWvWCLOs@ralph.baldwin.cx>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2018 17:07:34 -0000

On Tue, Mar 06, 2018 at 08:26:43AM -0800, John Baldwin wrote:
> The fact that there are back-to-back ABI breakages also suggests that it is
> much better to consolidate MFCs into larger commits [...]

+1.

> I think that going forward you shouldn't MFC changes if you aren't certain
> about the ABI implications until you have had someone review them.  Batching
> up changes into a single diff is also helpful since if an API changes back
> and forth in HEAD multiple times, collapsing them means that for stable you
> may only need a single compat shim rather than several.

+1.

./danfe