Date: Tue, 6 Mar 2018 17:07:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Eitan Adler <eadler@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 Message-ID: <20180306170733.GA84985@FreeBSD.org> In-Reply-To: <6465173.s2nWvWCLOs@ralph.baldwin.cx> References: <201803050754.w257swAE001435@repo.freebsd.org> <1861296.ksaTdANMae@ralph.baldwin.cx> <CAF6rxgk7v7OecuUWvRrJXg69uez6KmgnmrPtmExC4LmrjA8%2BDw@mail.gmail.com> <6465173.s2nWvWCLOs@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 06, 2018 at 08:26:43AM -0800, John Baldwin wrote: > The fact that there are back-to-back ABI breakages also suggests that it is > much better to consolidate MFCs into larger commits [...] +1. > I think that going forward you shouldn't MFC changes if you aren't certain > about the ABI implications until you have had someone review them. Batching > up changes into a single diff is also helpful since if an API changes back > and forth in HEAD multiple times, collapsing them means that for stable you > may only need a single compat shim rather than several. +1. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180306170733.GA84985>