From owner-svn-src-all@FreeBSD.ORG  Tue Oct 15 16:58:28 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9A774CFC
 for <svn-src-all@freebsd.org>; Tue, 15 Oct 2013 16:58:28 +0000 (UTC)
 (envelope-from mcdouga9@egr.msu.edu)
Received: from mail.egr.msu.edu (dauterive.egr.msu.edu [35.9.37.168])
 by mx1.freebsd.org (Postfix) with ESMTP id 6B74826CA
 for <svn-src-all@freebsd.org>; Tue, 15 Oct 2013 16:58:27 +0000 (UTC)
Received: from dauterive (localhost [127.0.0.1])
 by mail.egr.msu.edu (Postfix) with ESMTP id E730B3B625;
 Tue, 15 Oct 2013 12:58:20 -0400 (EDT)
X-Virus-Scanned: amavisd-new at egr.msu.edu
Received: from mail.egr.msu.edu ([127.0.0.1])
 by dauterive (dauterive.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id d3WZ2aH-R3Q1; Tue, 15 Oct 2013 12:58:20 -0400 (EDT)
Received: from daemon.localdomain (daemon.egr.msu.edu [35.9.44.65])
 by mail.egr.msu.edu (Postfix) with ESMTP id B79C53B61F;
 Tue, 15 Oct 2013 12:58:20 -0400 (EDT)
Received: by daemon.localdomain (Postfix, from userid 21281)
 id A0E7129317C; Tue, 15 Oct 2013 12:58:20 -0400 (EDT)
Date: Tue, 15 Oct 2013 12:58:20 -0400
From: Adam McDougall <mcdouga9@egr.msu.edu>
To: "Teske, Devin" <Devin.Teske@fisglobal.com>
Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts
Message-ID: <20131015165820.GO2097@egr.msu.edu>
References: <201310112041.r9BKfZeT002056@svn.freebsd.org>
 <20131015145032.GD98118@admin.xzibition.com>
 <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com>
 <525D5E07.1070900@allanjude.com>
 <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 Allan Jude <freebsd@allanjude.com>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2013 16:58:28 -0000

On Tue, Oct 15, 2013 at 04:28:21PM +0000, Teske, Devin wrote:

  >>>> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=1}
  >>>> 
  >>> > 
  >>> > 
  >>> I believe this trick is no longer needed after r254591.
  >>> 
  > 
  > This may be the case, I am not sure if r254591 'always' fixes the problem, maybe someone else can weight in with a more definite yes/no
  > 
  
  I'll hold off on doing anything with 4K sectors gnop hack until
  we get confirmation.
  
r254591 says:
"Use GEOM's stripesize attribute, if set, as the physical sector size of the GEOM."

I'm pretty sure GEOM only knows for a subset of devices, for example if the 
kernel contains a quirk based on the drive model.  If you are aiming for 
performance, my 2 cents is to keep it.  On the other hand, forcing 4k and thus 
ashift=12 wastes more space in a zpool on a 512b device so it would be nice to 
make this a toggle in the GUI defaulting to on.  If it is already, I apologize, I 
haven't tried the code in a few iterations.