From owner-cvs-all@FreeBSD.ORG Mon Oct 10 10:18:28 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42A6216A41F; Mon, 10 Oct 2005 10:18:28 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DDFB43D48; Mon, 10 Oct 2005 10:18:25 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0087C50B83; Mon, 10 Oct 2005 12:18:12 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0DA5450B1C; Mon, 10 Oct 2005 12:18:00 +0200 (CEST) Date: Mon, 10 Oct 2005 12:17:54 +0200 From: Pawel Jakub Dawidek To: Poul-Henning Kamp Message-ID: <20051010101754.GC3975@garage.freebsd.pl> References: <20051010101013.GB3975@garage.freebsd.pl> <13707.1128939139@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yLVHuoLXiP9kZBkt" Content-Disposition: inline In-Reply-To: <13707.1128939139@critter.freebsd.dk> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Peter Edwards , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, S?ren Schmidt Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2005 10:18:28 -0000 --yLVHuoLXiP9kZBkt Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2005 at 12:12:19PM +0200, Poul-Henning Kamp wrote: +> In message <20051010101013.GB3975@garage.freebsd.pl>, Pawel Jakub Dawide= k write +> s: +> > +> >On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote: +> >+> On 09/10/2005, at 23:11, Peter Edwards wrote: +> >+>=20 +> >+> Why did you ask me to review this when you just committed it anyway ? +> >+>=20 +> >+> As I said I'm not sure this is the right way to fix this.. +> > +> >It seems to be right. I do it in my GEOM classes to handle g_clone_bio() +> >failures better. So the only objection I may have is that it could be +> >done a bit cleaner: +>=20 +> Please see geom_disk.c So bascially, you allocate next bio before sending current one? That's one way of doing it, but I prefer to treat bio allocation as atomic operation, ie. if I cannot allocate all bios, I send no bio down and call g_io_deliver(parent_bio, ENOMEM) right away. Do you see any protential problems with doing so? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --yLVHuoLXiP9kZBkt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDSj/SForvXbEpPzQRAsCvAJ0TsTKLVhT2f1Xuq2WXAP7k6zeUlwCdEe2y 4Gu+dxjzEWODT491ddMgpLk= =iKo5 -----END PGP SIGNATURE----- --yLVHuoLXiP9kZBkt--