From owner-freebsd-current Thu Mar 7 14:31:14 2002 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 7BC2137B431; Thu, 7 Mar 2002 14:30:49 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g27MUl170046; Thu, 7 Mar 2002 14:30:47 -0800 (PST) (envelope-from dillon) Date: Thu, 7 Mar 2002 14:30:47 -0800 (PST) From: Matthew Dillon Message-Id: <200203072230.g27MUl170046@apollo.backplane.com> To: Warner Losh Cc: Julian Elischer , "Justin T. Gibbs" , John Baldwin , Bruce Evans , Terry Lambert , Alfred Perlstein , Bosko Milekic , Seigo Tanimura , FreeBSD current users Subject: Re: Patch for critical_enter()/critical_exit() & interrupt assem References: <200203072143.g27LhaL97112@harmony.village.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :: after reverting the change and silently waiting for a week :: 1/ no person bothered to review it. :: 2/ people assumed the patch had gone away. : :Ummm, There are reviews in the archives that object to the API as it :relates to optimization and those objections haven't been sanely :answered with anything more constructive than "BS". : :Warner I think John has a right to object to the work based on it being an optimization, but that should not sufficient reason in anyone's book to veto a commit, especially something that is as straightforward and obvious as I believe my work to be in this case. Unlike John, I am not the type of person who leaves hundreds of kilobytes of patches laying around my tree. For me completed work is either committable, or it should be thrown away. John's other objections - in regards to interference with future work, are completely unsubstantiated. He has not explained any reasoning for his objections AT ALL other then to make vague, undirected comments about how it doesn't fit with his idea of the world. He pointed me to a 10-page mini paper and I even after reading it I do not see how any of my work inteferes with anything he is doing. Not a single person beyond John has voiced ANY objection to work beyond the "wait for John to get back" objection and the "talk to John" objection. Not one person. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message