From owner-freebsd-stable@FreeBSD.ORG Fri Feb 24 17:54:37 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCAD81065670 for ; Fri, 24 Feb 2012 17:54:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 904108FC08 for ; Fri, 24 Feb 2012 17:54:37 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 47EB246B09; Fri, 24 Feb 2012 12:54:37 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id CF847B967; Fri, 24 Feb 2012 12:54:36 -0500 (EST) From: John Baldwin To: freebsd-stable@freebsd.org, pyunyh@gmail.com Date: Thu, 23 Feb 2012 09:46:20 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <20120215005600.GB1336@michelle.cdnetworks.com> In-Reply-To: <20120215005600.GB1336@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201202230946.20471.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 24 Feb 2012 12:54:36 -0500 (EST) Cc: Subject: Re: Regression in 8.2-STABLE bge code (from 7.4-STABLE) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 17:54:37 -0000 On Tuesday, February 14, 2012 7:56:00 pm YongHyeon PYUN wrote: > On Sat, Jan 28, 2012 at 09:24:53PM -0500, Michael L. Squires wrote: > > Sorry for late reply. Had been busy due to relocation. > > > There is a bug in the Tyan S4881/S4882 PCI-X bridges that was fixed with a > > patch in 7.x (thank you very much). This patch is not present in the > > 8.2-STABLE code and the symptoms (watchdog timeouts) have recurred. > > > > Hmm, I thought the mailbox reordering bug was avoided by limiting > DMA address space to 32bits but it seems it was not right workaround > for AMD 8131 PCI-X Bridge. > > > The watchdog timeouts do not appear to be present after I switched to an > > Intel gigabit PCI-X card. > > > > I did a brute-force patch of the 8.2-STABLE bge code using the patches for > > 7.4-STABLE; the resulting code compiled and, other than odd behavior at > > startup, seems to be working normally. > > > > This is using FreeBSD 8.2-STABLE amd64; I don't know what happens with > > i386. > > > > Given the age of the boards it may be easier if I just continue using the > > Intel gigabit card but am happy to test anything that comes my way. > > > > Try attached patch and let me know how it goes. > I didn't enable 64bit DMA addressing though. I think the AMD-8131 > PCI-X bridge needs both workarounds. Eh, please don't do the thing where you walk all pcib devices. Instead, walk up the tree like so: static int bge_mbox_reorder(struct bge_softc *sc) { devclass_t pcib, pci; device_t dev, bus; pci = devclass_find("pci"); pcib = devclass_find("pcib"); dev = sc->dev; bus = device_get_parent(dev); for (;;) { dev = device_get_parent(bus); bus = device_get_parent(dev); if (device_get_devclass(dev) != pcib_devclass || device_get_devclass(bus) != pci_devclass) break; /* Probe device ID. */ } return (0); } It is not safe to use pci_get_vendor() with non-PCI devices (you may get random junk, and Host-PCI bridges are not PCI devices). Also, this will only apply the quirk if a relevant bridge is in the bge device's path. -- John Baldwin