From owner-freebsd-current  Tue Feb 25 13:49:18 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CEAFB37B401
	for <current@FreeBSD.ORG>; Tue, 25 Feb 2003 13:49:16 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7F32B43F85
	for <current@FreeBSD.ORG>; Tue, 25 Feb 2003 13:49:16 -0800 (PST)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 55AD7AE27F; Tue, 25 Feb 2003 13:49:16 -0800 (PST)
Date: Tue, 25 Feb 2003 22:49:16 +0100
From: Maxime Henrion <mux@freebsd.org>
To: Morten Rodal <morten@rodal.no>
Cc: current@FreeBSD.ORG
Subject: Re: patch for the nVidia driver and -CURRENT
Message-ID: <20030225214916.GC18565@elvis.mu.org>
References: <20030225182809.GA18565@elvis.mu.org> <20030225214529.GA19651@slurp.rodal.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030225214529.GA19651@slurp.rodal.no>
User-Agent: Mutt/1.4i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Morten Rodal wrote:
> On Tue, Feb 25, 2003 at 07:28:09PM +0100, Maxime Henrion wrote:
> [snip a lot of the patch]
> > @@ -1431,7 +1442,8 @@
> >      SLIST_FOREACH(at, &sc->alloc_list, list) {
> >          if (offset >= at->address &&
> >                  offset < at->address + at->size)
> > -            return atop(vtophys(offset));
> > +            *paddr = vtophys(offset);
> > +            return 0;
> >      }
> >  
> >      return -1;
> 
> Should the function return 0 even if the if (offset..) fails?  I have
> no clue about the nvidia kernel driver (or kernel stuff at all) but it
> seems to me that the only way the function can return -1 is if the
> list is empty.

And this is consistant with what the code was doing before.  This change
is not a functional change, it's just a necessary update due to API
changes.

Cheers,
Maxime

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message