From owner-freebsd-current@FreeBSD.ORG Thu Mar 6 01:14:28 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FE831065671 for ; Thu, 6 Mar 2008 01:14:28 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id 351C48FC14 for ; Thu, 6 Mar 2008 01:14:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so493046anc.13 for ; Wed, 05 Mar 2008 17:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=agWqFFCgscV/6irE7NaeEBSAkoLKvztNrg1O+7dZvhs=; b=ImjXTJJKKLtEWCQopC+O4n4szPjXFuaMpHrYaSroh72j1iTexCMAJKBl9X8+PDYPlD2DzrG6tHT2C5ciwbQZavpR5ibD2FlGcFXVPq3jfA742V+5A7Y3wDixcSBhO1wxjeEcgVrCqy8GmTLtAkCrydgmmBzXfjzuzqUPhtiwATg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=uhBP+7PkCv3f9J4n1GY0IVheQEAiA4kwTxU91Wf8iAfIi7f43WhyLc0KtE5el7pW05ObVyH9vutAvJxEjLKm0NrxbZYHOHfLMnULLSxl3g4Idwv6gL4LP4sFuJ+rd0Nz0KswOJkJbtXdgWDbdCGUwZvbqtigVMJEJw2/d6RiuOA= Received: by 10.100.121.12 with SMTP id t12mr8424850anc.113.1204766067306; Wed, 05 Mar 2008 17:14:27 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id 3sm2808378wrs.22.2008.03.05.17.14.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Mar 2008 17:14:26 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m261ELCo087532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 Mar 2008 10:14:21 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m261EKbZ087531; Thu, 6 Mar 2008 10:14:20 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Thu, 6 Mar 2008 10:14:20 +0900 From: Pyun YongHyeon To: Mike Tancsa Message-ID: <20080306011420.GB87113@cdnetworks.co.kr> References: <20080217112104.X80805@fledge.watson.org> <200803011655.m21GtcMU078673@lava.sentex.ca> <20080303013142.GE72895@cdnetworks.co.kr> <200803031010.28087.freebsd-current@dino.sk> <20080303104140.GA74947@cdnetworks.co.kr> <47CC2F0F.2000808@nixil.net> <20080304023108.GA78525@cdnetworks.co.kr> <200803051617.m25GHwQW002107@lava.sentex.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803051617.m25GHwQW002107@lava.sentex.ca> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@freebsd.org Subject: Re: CFT: vr(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2008 01:14:28 -0000 On Wed, Mar 05, 2008 at 11:20:00AM -0500, Mike Tancsa wrote: > At 09:31 PM 3/3/2008, Pyun YongHyeon wrote: > > >It seems that I've made mistake in implementing memory mapped > >register access. Even if datasheet says no special things for > >reloading EEPROM, Rhine family seems to default to io register > >access after reloading EEPROM. I guess this would be root cause of > >Milan Obuch's issue. It seems that his hardware requires memory > >mapped register access but reloading EEPROM disabled it. > >ATM I have no clean idea how can I renable memory mapped register > >access after EEPROM reloading without hacks so I completely backed > >out memory mapped register access and put updated vr(4) to the same > >URL. Please try again updated vr(4) and let me know how it goes. > > Hi, > I tried both the if_vr.c and if_vr.c.memio version on > RELENG_7 and it seems fine on my hardware. I also check and > confirmed vlans were still working. Thanks again for fixing this > driver! BTW, for the RELENG_6, we implemented a userland work around > to deal with when the nic bounces. > memio version seems to need more work. I'll commit without memio function after fixing a regression reported by Phil Oleson. Thank you. -- Regards, Pyun YongHyeon