From owner-svn-src-all@FreeBSD.ORG Wed Jan 5 19:10:07 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59D461065672; Wed, 5 Jan 2011 19:10:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 02F328FC0C; Wed, 5 Jan 2011 19:10:07 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 5849D41C64A; Wed, 5 Jan 2011 20:10:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id bXToCCiXBkhZ; Wed, 5 Jan 2011 20:10:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id D97CA41C62D; Wed, 5 Jan 2011 20:10:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 5F05F4448F3; Wed, 5 Jan 2011 19:09:10 +0000 (UTC) Date: Wed, 5 Jan 2011 19:09:10 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Marius Strobl In-Reply-To: <20110105155513.GA97101@alchemy.franken.de> Message-ID: <20110105185451.W14966@maildrop.int.zabbadoz.net> References: <201101051528.p05FSVPL082696@svn.freebsd.org> <20110105153107.X14966@maildrop.int.zabbadoz.net> <20110105155513.GA97101@alchemy.franken.de> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r217013 - in head: sbin/ifconfig sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2011 19:10:07 -0000 On Wed, 5 Jan 2011, Marius Strobl wrote: > On Wed, Jan 05, 2011 at 03:34:30PM +0000, Bjoern A. Zeeb wrote: >> On Wed, 5 Jan 2011, Marius Strobl wrote: >> >>> Author: marius >>> Date: Wed Jan 5 15:28:30 2011 >>> New Revision: 217013 >>> URL: http://svn.freebsd.org/changeset/base/217013 >>> >>> Log: >>> Teach ifconfig(8) the handy shared option shortcut aliases the NetBSD >>> counterpart also takes, i.e. "fdx" for "full-duplex", "flow" for >>> "flowcontrol", "hdx" for "half-duplex" as well as "loop" and "loopback" >>> for "hw-loopback". >> >> I am not sure this is a good idea. Unless this is really really >> useful for compatibility with scripts (which I doubt) it'll sooner or >> later cause headaches, especially given some of the (new) names could >> be very well used for different things as well. > > Could you please elaborate on what different use you have in mind? > Generally it seems a bad idea to me if the existing options and the > new names as implemented would trigger different things as you suggest > given the latter are rather common abbreviations as well as diverging > from the user interface of the other BSDs seems like a bad idea (i.e. > not only not supporting the same names they do but also controlling > different things with a given one). Also the concept of aliases taken > by ifconfig(8) isn't new, we support several including f.e. "auto" for > "autoselect" for quite some time. "flow" is a term used at other layers as well and really different to flow control. We are not only seeing discussions about flowid usage in IPv6 but also people trying to control "ULP flows" on NICs (RSS). loop and loopback sound bad as well, especially as I could only see one man page in man4 (tl.4) that actually references it. My worries are just that people will confuse those things with other options outside of media-opts. I guess I have no problem with fdx and hdx but you will see a mix other either showing up then in scripts and man pages and that'll give an incosistent view to users and confuse them as well (especially since those options are all descriped with the driver's man pages rather than having a global list [if needed with aliases] in ifconfig then refering to the driver man pages to see which of those a driver actually supports). To give you an example -- "add" is an alias for "alias" with inet, and people are writing alias where add should be (different places on the command line) which leads to confusion as it shouldn't work there and doesn't for IPv6. Much confusion for years. /bz -- Bjoern A. Zeeb You have to have visions! Going to jail sucks -- All my daemons like it! http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html