Date: Sun, 15 Jul 2018 12:06:47 -0600 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com>, "K. Macy" <kmacy@freebsd.org> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] Recent libm additions Message-ID: <1531678007.26036.10.camel@freebsd.org> In-Reply-To: <CANCZdfrYrz0971Grk5E-hrQd%2BAPZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> <CAHM0Q_OMYUe4CDemC8Gx9AGzA%2BwK0cctwUhHieeQi2xdDs0urA@mail.gmail.com> <CANCZdfrYrz0971Grk5E-hrQd%2BAPZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy@freebsd.org> wrote: > > > > > > > > > > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > > > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. > > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1531678007.26036.10.camel>