From owner-freebsd-ports@FreeBSD.ORG  Wed May 23 02:04:42 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 744C7106566C;
	Wed, 23 May 2012 02:04:42 +0000 (UTC) (envelope-from bobf@mrp3.com)
Received: from elasmtp-galgo.atl.sa.earthlink.net
	(elasmtp-galgo.atl.sa.earthlink.net [209.86.89.61])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A7288FC15;
	Wed, 23 May 2012 02:04:42 +0000 (UTC)
Received: from [66.47.136.67] (helo=hack.SFT.local)
	by elasmtp-galgo.atl.sa.earthlink.net with esmtpsa
	(TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from <bobf@mrp3.com>)
	id 1SX0wG-0006ft-Dx; Tue, 22 May 2012 22:04:36 -0400
Message-ID: <4FBC45AD.4080107@mrp3.com>
Date: Tue, 22 May 2012 19:04:29 -0700
From: Bob Frazier <bobf@mrp3.com>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:8.0) Gecko/20111231 Thunderbird/8.0
MIME-Version: 1.0
To: Jason Helfman <jgh@FreeBSD.org>
References: <20120521220449.GD8317@dormouse.experts-exchange.com>
In-Reply-To: <20120521220449.GD8317@dormouse.experts-exchange.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-ELNK-Trace: 549015f0ad0344773aad58b8ed06a5f90a9da525759e265472662d6aa87c5f14b4f119d4633d9458cd0c042b896368d8350badd9bab72f9c350badd9bab72f9c
X-Originating-IP: 66.47.136.67
Cc: ports@freebsd.org
Subject: Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is
 defined before referenced
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 May 2012 02:04:42 -0000

On 05/21/12 15:04, Jason Helfman so wittily quipped:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I am working on the following pr, and would like to get others approval to
> the following patch:
> http://people.freebsd.org/~jgh/files/pre-patch.txt
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994
>
> This patch is fixing several use cases of SRC_BASE before it is defined.

(re: comms/uarduno port)

Now that I understand what the patch is for I totally agree, it should 
be applied to comms/uarduno as well.  I believe I copied my port from 
one of the others that had the 'bad logic' in it, so thanks for catching it.

Do I need to make the change or are you going to do it on your end?