From owner-p4-projects@FreeBSD.ORG Thu Mar 4 22:51:23 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1411916A4D0; Thu, 4 Mar 2004 22:51:23 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB93F16A4CE; Thu, 4 Mar 2004 22:51:22 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id A357843D46; Thu, 4 Mar 2004 22:51:22 -0800 (PST) (envelope-from peter@evilpete.dyndns.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id 5D8122A8DA; Thu, 4 Mar 2004 22:51:22 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from overcee.wemm.org (unknown [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id 08AEE2C1AC; Thu, 4 Mar 2004 22:51:22 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from overcee.wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (8.12.11/8.12.10) with ESMTP id i256pKjT057840; Thu, 4 Mar 2004 22:51:20 -0800 (PST) (envelope-from peter@overcee.wemm.org) Received: from localhost (localhost [[UNIX: localhost]]) by overcee.wemm.org (8.12.11/8.12.10/Submit) id i256pKpJ057839; Thu, 4 Mar 2004 22:51:20 -0800 (PST) (envelope-from peter) From: Peter Wemm To: obrien@FreeBSD.org Date: Thu, 4 Mar 2004 22:51:20 -0800 User-Agent: KMail/1.6 References: <200403040613.i246DLgM015954@repoman.freebsd.org> <20040305061315.GB58624@dragon.nuxi.com> In-Reply-To: <20040305061315.GB58624@dragon.nuxi.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403042251.20025.peter@wemm.org> cc: Perforce Change Reviews cc: Peter Wemm Subject: Re: PERFORCE change 48112 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2004 06:51:23 -0000 On Thursday 04 March 2004 10:13 pm, David O'Brien wrote: > On Wed, Mar 03, 2004 at 10:13:21PM -0800, Peter Wemm wrote: > > http://perforce.freebsd.org/chv.cgi?CH=48112 > > > > Change 48112 by peter@peter_daintree on 2004/03/03 22:12:27 > > > > Umm. VESA doesn't exist on amd64. Sorry David. > > I know -- I still wanted as much of sys/i386/conf/NOTES enabled as > made [*]sense. > > -- David > [*] you might expand this as "semi-", "doesn't", or "". The problem is that we have some entries in options.amd64 that have no backing code. This stops config from detecting the error. Its important that we don't silently accept options that don't do anything. VESA and VESA_DEBUG merely cause an entry to be made in opt_vesa.h - but nothing ever #include's it. Allowing config to silently accept it means that people will get POLA when they wonder why the heck the VESA driver isn't working when the options are in their kernel and it didn't fail to compile. The fact that its not actually there is certainly a POLA violation. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5